Skip to content

Feature: Use Add-On Shelly Digital Input to prevent cover usage with open windows - #219

Merged
orlin369 merged 5 commits into
ALLTERCO:mainfrom
Khoulaiz:main
Oct 15, 2026
Merged

orlin369 merged 5 commits into
ALLTERCO:mainfrom
Khoulaiz:main

Conversation

@Khoulaiz

Copy link
Copy Markdown
Contributor

Motivation:

  • Window is interfering with the cover if the window is open
  • prevent Shelly to close the cover if the window is open or stop closing it when window is being opened
  • use the AddOn Shelly for a smart home hub independent local solution inside the Shelly

@Khoulaiz Khoulaiz changed the title Use Add-On Shelly Digital Input to prevent cover usage with open windows Feature: Use Add-On Shelly Digital Input to prevent cover usage with open windows Sep 15, 2026
@orlin369

Copy link
Copy Markdown
Contributor

The file looks good to me. Please just make the following two adjustments:

  1. Update the file header to follow the convention we use across the repository.

For example:

/**
 * @title Deye SG02LP1 MODBUS-RTU + Virtual Components
 * @description MODBUS-RTU reader for Deye SG02LP1 solar inverter with
 *   Virtual Component updates. Reads parameters over UART (RS485) and
 *   pushes values to user-defined virtual number components.
 * @status production
 * @link https://github.com/ALLTERCO/shelly-script-examples/blob/main/the_pill/MODBUS/Deye/deye_vc.shelly.js
 */
  1. Update examples-manifest.json with the new example so that it becomes visible and accessible from the app:

https://github.com/ALLTERCO/shelly-script-examples/blob/main/examples-manifest.json

Once these two changes are made, everything looks good from my side.

@Khoulaiz

Khoulaiz commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

@orlin369 Added the missing header and entry in the examples-manifest. Sorry, for not noticing myself, that this exist.

@orlin369

orlin369 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

I am sorry for bothering you but the JS file name should be .shelly.js

The CI/DC does not let me move forward, please fix the file extension.

Best regards, Orlin

@Khoulaiz

Copy link
Copy Markdown
Contributor Author

Once again, sry that I didn't see that myself.
I also had some trouble with the json formatting.
May I suggest to add a

 "printWidth": 1000

to your .prettierrc (with the value you prefer)? Right now the formatting of the example.manifest.json is inconsistent, causing merge conflicts here and there.

@orlin369
orlin369 merged commit eb4e0cb into ALLTERCO:main Oct 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants