Fix misleading preemption logs in checkpointing#4124
Open
lukebaumann wants to merge 1 commit into
Open
Conversation
- Raise JaxRuntimeError directly instead of masking it as StopTraining('Job is preempted.') when elasticity is disabled. This prevents hiding the true cause of crashes in logs and allows proper crash handling.
- Reword StopTraining message when reached_preemption is true to 'Job received termination signal (SIGTERM).' as SIGTERM is sent for various termination events (scaling, updates), not just preemption.
Fixes: b/516962538
lukebaumann
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
bvandermoon
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve misleading "Job is preempted" error logs in MaxText checkpointing.
Changes
JaxRuntimeErrorand raisingStopTraining("Job is preempted.")when elasticity is disabled, we now let the exception bubble up. This allows the process to crash normally, preventing silent failures and ensuring the logs show the actual cause of the crash (e.g. OOM).StopTrainingmessage whenreached_preemptionis true to"Job received termination signal (SIGTERM)."since SIGTERM is sent by GKE/Kueue for various non-preemption events (e.g., updates, scaling down).Fixes: b/516962538