Fix elastic manager initialization bug when elastic is disabled#4119
Open
lukebaumann wants to merge 1 commit into
Open
Fix elastic manager initialization bug when elastic is disabled#4119lukebaumann wants to merge 1 commit into
lukebaumann wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Wrap elastic check condition into should_use_elastic and use it in ensure_elastic_manager_initialized and live_devices to avoid crash when elastic_enabled is False but pathways is used. Bug: http://b/521670882
72bed8b to
a5233cf
Compare
abhinavclemson
approved these changes
Jun 9, 2026
gobbleturk
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the workload fails with AssertionError: assertion elastic_manager is not None when elastic training is disabled but the Pathways backend is used.
Root Cause
In elastic_utils.py,
live_devices()checked if the Pathways backend was used, but did not verify ifelastic_enabledwas True before callingensure_elastic_manager_initialized()and asserting thatelastic_manager is not None. Sinceelastic_enabledwas False,elastic_managerwas never initialized, leading to the assertion failure.Solution
Introduced a helper function
should_use_elastic(config)which safely checks if the configuration is present and if elastic training is enabled (usingelastic_enabled(config)).Refactored
ensure_elastic_manager_initializedandlive_devicesto useshould_use_elastic(config)instead of partial checks.Wrap elastic check condition into should_use_elastic and use it in ensure_elastic_manager_initialized and live_devices to avoid crash when elastic_enabled is False but pathways is used.
Tests
Added a unit test
test_live_devices_disabledto cover the case where pathways is used but elastic is disabled.FIXES: b/521670882
Verified: b/521670882#comment4
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.