Fix Oyr.osaltdiff discovery with yearly-only aggregation#441
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=====================================
Coverage 76.4% 76.4%
=====================================
Files 31 31
Lines 5909 5913 +4
Branches 1092 1094 +2
=====================================
+ Hits 4515 4519 +4
Misses 1154 1154
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Scientific caveat — do not merge yetAfter opening this PR, further investigation raised a concern about the correctness of the Current mapping: Why these may differ
StatusThis PR provides the infrastructure (frequency-specific file discovery, yearly-only aggregation wiring) which is correct and reusable regardless of which source variable is ultimately used. However, the mapping itself ( Keeping this open for review/discussion but not ready to merge until the source variable choice is confirmed. |
Summary
This PR addresses #199 by allowing Oyr.osaltdiff to be generated from available monthly ACCESS output, while ensuring aggregation behavior only applies to yearly ocean requests.
What changed
Why this resolves #199
Issue #199 reports missing salt_vdiffuse_diff_cbt for Oyr.osaltdiff. In current outputs, salt_vdiffuse_impl is available monthly. This PR enables Oyr.osaltdiff to discover that monthly input and aggregate to yearly only when yearly output is requested.