Repository navigation
ci: run PR Check for pull requests into dev - #1392
Open
BuddhaDiedLaughing wants to merge 1 commit into
Open
BuddhaDiedLaughing wants to merge 1 commit into
BuddhaDiedLaughing wants to merge 1 commit into
Conversation
The trigger names `development`, which no longer exists: git/ref/heads/development returns 404 while heads/dev returns 200, and every PR opened into dev since 2026-10-06 carries zero check-runs. Renaming the filter to `dev` restores the check.
BuddhaDiedLaughing
marked this pull request as ready for review
October 22, 2026 02:37
CATMIAOZHI
self-requested a review
October 22, 2026 08:00
CATMIAOZHI
approved these changes
Oct 22, 2026
CATMIAOZHI
left a comment
Collaborator
There was a problem hiding this comment.
审计结论:✅ 批准合并
改动(1 文件,+1/−1):将 pr-check.yml 工作流 pull_request 触发条件从已不存在的 development 分支修正为 dev,使目标分支为 dev 的 PR 重新触发 PR Check。
通过的检查:
- 目标分支为
dev,符合项目规范。 - 作者的问题定位已独立核实:
GET /git/ref/heads/development返回 404(分支确实不存在),GET /git/ref/heads/dev返回 200,触发条件指向死分支的诊断成立。 - 全仓库 workflow 扫描:只有
pr-check.yml一处引用development,本次 diff 已是完整修复,无遗漏。 - diff 与 PR 描述完全一致(仅一行触发条件改动,无无关内容);改动前后工作流文件语法正确。
- 作者已如实说明未本地运行验证的原因(本机无仓库、无 CI);该类触发条件修复的验证只能在合并后通过新 dev PR 的实际触发确认,符合预期。
问题:
- [P3] 建议合并后人工确认一次:任意以
dev为目标的新 PR 的 head commit 上应出现 PR Check 运行(与作者验证方式一致)。
后续可跟进(不阻塞):无。
由 水晴喵的muse 审计
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明 / Description
pr-check.yml的触发条件写的是branches: [development],但该分支已经不存在:GET /git/ref/heads/development返回404,heads/dev返回200。后果是目标分支为dev的 PR 不会触发 PR Check。证据 / Evidence:
GET /repos/AAswordman/Operit/actions/workflows/336312249/runs-> 历史上共265次运行,最后一次是 2026-10-06 的ci/fix-pr-check-dev-branch(failure),说明它此前一直在跑devPR(feat(provider): add TokenRhythm as a built-in LLM provider #1377、fix(local): stop truncating local replies at the native 256-token cap #1385 - fix(model-config): realign thinking option after rule or model edits #1391)在 head commit 上check-runs数量均为01f4787e4) 起未改动,因此不是工作流本身的问题改动 / Changes
branches: [development]->branches: [dev],一行验证方式 / Verification
本机没有克隆仓库、没有运行 CI;改动是一行触发条件。合并后,任何一个以
dev为目标的 PR 都应出现PR Check运行。检查清单 / Checklist
dev(日常开发 PR)