Skip to content

ci: run PR Check for pull requests into dev - #1392

Open
BuddhaDiedLaughing wants to merge 1 commit into
AAswordman:devfrom
BuddhaDiedLaughing:fix/pr-check-base-branch
Open

BuddhaDiedLaughing wants to merge 1 commit into
AAswordman:devfrom
BuddhaDiedLaughing:fix/pr-check-base-branch

Conversation

@BuddhaDiedLaughing

Copy link
Copy Markdown

变更说明 / Description

pr-check.yml 的触发条件写的是 branches: [development],但该分支已经不存在:GET /git/ref/heads/development 返回 404,
heads/dev 返回 200。后果是目标分支为 dev 的 PR 不会触发 PR Check。

证据 / Evidence:

改动 / Changes

  • branches: [development] -> branches: [dev],一行

验证方式 / Verification

本机没有克隆仓库、没有运行 CI;改动是一行触发条件。合并后,任何一个以 dev 为目标的 PR 都应出现 PR Check 运行。

检查清单 / Checklist

  • 目标分支为 dev(日常开发 PR)
  • 最终 diff 无无关内容
  • 已说明未在本地运行验证的原因

The trigger names `development`, which no longer exists: git/ref/heads/development
returns 404 while heads/dev returns 200, and every PR opened into dev since
2026-10-06 carries zero check-runs. Renaming the filter to `dev` restores the check.
@BuddhaDiedLaughing
BuddhaDiedLaughing marked this pull request as ready for review October 22, 2026 02:37
@CATMIAOZHI
CATMIAOZHI self-requested a review October 22, 2026 08:00

@CATMIAOZHI CATMIAOZHI left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

审计结论:✅ 批准合并

改动(1 文件,+1/−1):将 pr-check.yml 工作流 pull_request 触发条件从已不存在的 development 分支修正为 dev,使目标分支为 dev 的 PR 重新触发 PR Check。

通过的检查:

  • 目标分支为 dev,符合项目规范。
  • 作者的问题定位已独立核实:GET /git/ref/heads/development 返回 404(分支确实不存在),GET /git/ref/heads/dev 返回 200,触发条件指向死分支的诊断成立。
  • 全仓库 workflow 扫描:只有 pr-check.yml 一处引用 development,本次 diff 已是完整修复,无遗漏。
  • diff 与 PR 描述完全一致(仅一行触发条件改动,无无关内容);改动前后工作流文件语法正确。
  • 作者已如实说明未本地运行验证的原因(本机无仓库、无 CI);该类触发条件修复的验证只能在合并后通过新 dev PR 的实际触发确认,符合预期。

问题:

  1. [P3] 建议合并后人工确认一次:任意以 dev 为目标的新 PR 的 head commit 上应出现 PR Check 运行(与作者验证方式一致)。

后续可跟进(不阻塞):无。

由 水晴喵的muse 审计

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants