Repository navigation
Conversation
…passes `hermes plugins validate` fails at HEAD with `capability probe: register() raised: unable to open database file`. `register()` calls `facts.ensure_schema(config.FACT_DB)`, and `FACT_DB` lives under `$HERMES_HOME/plugins/cronalytics/`, which does not exist in a fresh `HERMES_HOME` (validate probes against a temp home; the same happens on a first-time install before anything else creates that directory). This adds a `Path(db_path).parent.mkdir(parents=True, exist_ok=True)` in `ensure_schema()` before `sqlite3.connect`, which is the single choke point every fact-DB connection goes through (`get_conn()` also routes through it). No other behaviour changes. Before: `capability probe: register() raised: unable to open database file` → `ok: false` After: `capability probe: register() ran in isolation` → `ok: true` (checked on both the main checkout venv and a bare Python 3.11 install). With this merged, `hermes plugins validate` passes and Hermes maintainers can list the plugin in the plugin catalog at the merged commit (see NousResearch/hermes-agent#112292 for the sweep).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hermes plugins validatefails at HEAD withcapability probe: register() raised: unable to open database file.register()callsfacts.ensure_schema(config.FACT_DB), andFACT_DBlives under$HERMES_HOME/plugins/cronalytics/, which does not exist in a freshHERMES_HOME(validate probes against a temp home; the same happens on a first-time install before anything else creates that directory).This adds a
Path(db_path).parent.mkdir(parents=True, exist_ok=True)inensure_schema()beforesqlite3.connect, which is the single choke point every fact-DB connection goes through (get_conn()also routes through it). No other behaviour changes.Before:
capability probe: register() raised: unable to open database file→ok: falseAfter:
capability probe: register() ran in isolation→ok: true(checked on both the main checkout venv and a bare Python 3.11 install).With this merged,
hermes plugins validatepasses and Hermes maintainers can list the plugin in the plugin catalog at the merged commit (see NousResearch/hermes-agent#112292 for the sweep).