fix(responses): make WebSearchActionFind.url optional#574
Open
hzargar2 wants to merge 1 commit into
Open
Conversation
The Responses API omits `url` on `find` / `find_in_page` web-search actions that continue within a page already opened by a prior `open_page` action. Because `WebSearchActionFind.url` is a required `String`, deserializing such a response fails with `missing field `url``, which aborts parsing of the entire response for any web search that uses find-in-page continuation. Make `url` an `Option<String>`, mirroring the already-optional `WebSearchActionOpenPage::url`. No other code constructs the struct and `cargo check` passes. Cut on top of async-openai-v0.36.1 to match the sec workspace pin (`async-openai = "0.36.1"`); a patch built on a newer minor would not satisfy the `^0.36.1` requirement and cargo would silently drop it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Responses API omits
urlonfind/find_in_pageweb-search actions that continue within a page already opened by a prioropen_pageaction. BecauseWebSearchActionFind.urlis a requiredString, deserializing such a response fails withmissing fieldurl``, which aborts parsing of the entire response for any web search that uses find-in-page continuation.Make
urlanOption<String>, mirroring the already-optionalWebSearchActionOpenPage::url. No other code constructs the struct andcargo checkpasses.