Repository navigation
luckfox: UART console off by default, seedsigner-os images always dev, dev levers in file names - #144
Merged
Merged
Conversation
…, tag dev levers in names A user's Pico showed the secure-boot screen and never reached the app. Their card was a byte-exact copy of the seedsigner-os SeSi-0.8.7+ShSi-B13-pre release image: a non-dev build with disable_uart2_console_debug=false. It was named "...-osproduction-signed-devkey", identical to the app repo's working release image, so nothing told the two apart. - os-build.sh: disable_uart2_console_debug=auto now strips the serial console on every variant (it used to keep it on dev). Only an explicit false keeps it. build-local.sh already defaulted to stripped. - build-luckfox.yml: runs in */seedsigner-os always build dev, and the dispatch form drops build_variant. Production images come from the app repo via workflow_call, where github.repository is the caller, so it is unaffected. - New opt/luckfox/artifact-tag.sh, shared by os-build.sh and build-local.sh. It adds -dev-uart / -dev-testing on any variant, plus -dev-adb, -dev-otg, -dev-net, -dev-rw, -dev-bootlog and -dev-adbfiles on a production build. Clean production names are unchanged. - docs/luckfox/README.md: the variant policy, an artifact-name table, and a Troubleshooting section (stuck on the secure-boot screen; no Maskrom/Loader device in SocToolKit -> install RK Driver Assistant). - tests/test_luckfox_artifact_tag.sh covers the naming rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve conflicts with #138, which landed the same UART default independently (console + FIQ debugger stripped on every variant). Main's resolve_uart2_console() and its wording win: only false/0 keeps the console and anything else strips it, which fails safe. Added on top: the -dev-uart artifact tag, the note that a console-on Pico stalls after the secure-boot screen, and seedsigner-os builds being forced to dev (so main's reworded build_variant dispatch input stays removed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A user's Luckfox Pico showed the secure-boot screen and never reached SeedSigner. I unpacked their two card dumps (HDD Raw Copy
.imgc):SeSi-0.8.7+ShSi-B13-prerelease image…-mini-sd-SeSi-0.8.7_ShSi-B13-pre-osproduction-signed-devkey.img(sha25691e6b65d…). The app repo release has the same file name with different contents (efd3a910…), and that one boots.-prerelease image (63c1a1a4…).earlycon=… console=ttyFIQ0in boot.img. The B13-pre release run wasbuild_variant=non-devwithdisable_uart2_console_debug=false, so the console was on while the name saidosproduction. The card data itself was intact.Changes
os-build.shresolve_uart2_console):autoused to keep it on dev builds, and those don't boot through to the app. Only an explicitfalsekeeps it now.build-local.shalready defaulted to stripped.build-luckfox.yml): forced whenevergithub.repositoryends in/seedsigner-os, and the dispatch form no longer offersbuild_variant. Inside aworkflow_call,github.repositoryis the caller, so the app repo's production builds (which passbuild_variant: non-dev) are unaffected.opt/luckfox/artifact-tag.shis used by bothos-build.shandbuild-local.sh, so the two can't drift. Format:<appref>-os<develop|production>[-dev-<lever>...]-<signing>.-dev-uartand-dev-testingon any variant-dev-adb,-dev-otg,-dev-net,-dev-rw,-dev-bootlog,-dev-adbfileson production builds whose levers are off their production defaultsSeSi-0.8.7_ShSi-B13-osproduction-signed-devkey)docs/luckfox/README.md): the variant policy, an artifact-name table, and a new Troubleshooting section:Testing
bash tests/test_luckfox_artifact_tag.sh: all cases pass, including the B13-pre case, which now yields…-osproduction-dev-uart-signed-devkey.bash -non every changed script; the workflow YAML parses.console=ttyFIQ0.Follow-up (not in this PR)
The existing seedsigner-os releases (B12-pre, B13-pre, …) still carry the misleading names. Consider renaming or removing those assets, or adding a warning to their release notes.
🤖 Generated with Claude Code