Add F-rep implicit fields to primitive shapes#133
Merged
Conversation
Box, Sphere, Cylinder, Capsule, Ellipsoid each set _func / _bounds in __init__ via a per-class _setup_frep_field. SDF formulas verbatim from PR #116 (fast O(1) closures, no autograd), with center and orientation baked directly into the field. CAD generate() and pyvista generate_vtk() overrides untouched — only :meth:`generate` requires the [cad] extra. Operators |, &, -, ~ now compose primitives directly: `Sphere(...) & Box(...)` returns a Shape with a composed implicit field, no CAD or to_implicit() conversion required. Tests in tests/shapes/test_primitive_implicit.py: SDF sign at center / surface / outside, AABB validity, center translation, orientation, composability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Box, Sphere, Cylinder, Capsule, Ellipsoid each set _func / _bounds in
init via a per-class _setup_frep_field. SDF formulas verbatim from
PR #116 (fast O(1) closures, no autograd), with center and orientation
baked directly into the field. CAD generate() and pyvista generate_vtk()
overrides untouched — only :meth:
generaterequires the [cad] extra.Operators |, &, -, ~ now compose primitives directly:
Sphere(...) & Box(...)returns a Shape with a composed implicit field, no CAD orto_implicit() conversion required.
Tests in tests/shapes/test_primitive_implicit.py: SDF sign at center /
surface / outside, AABB validity, center translation, orientation,
composability.