Repository navigation
Remove donor-repo leftovers - #5
Merged
Merged
Conversation
- playwright_scraper --retries help and retry comment: "empty hub category" / "one page past the end of a listing" replaced with the twins' wording (SEO landing page or cityless URL); CONTRIBUTING too. - bug_report "96 products ... category page" placeholder -> 20 cars per scrolled batch. - captcha_solver.py: dangling "No DataDome solver" reference removed. - SECURITY.md: no longer claims the project has no releases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jehrr
force-pushed
the
fix/donor-leftovers
branch
from
September 28, 2026 19:50
7b7f27b to
bc1e4bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
--help:playwright_scraper.py --retriessaid "an empty hub category is a correct answer" (Tokopedia's wording). Now matches the pyppeteer/Selenium engines, which already said it right: an SEO landing page or a cityless URL having no grid.playwright_scraper.pyretry comment said "one page past the end of a listing has no products", which cannot happen on a site that ignores?page=N. Rewritten to the two empty cases this repo measures.CONTRIBUTING.mdexit-code bullet: "including a hub category" -> "including an SEO landing page or a cityless URL".bug_report.ymlplaceholder "96 products, as the README says a category page yields" (Farfetch's figure) -> "About 20 cars per scrolled batch" (README: 20 cars per batch).captcha_solver.py: removed "See 'No DataDome solver' below", which points at a section that does not exist.SECURITY.mdsaid "no releases or version tags"; v0.1.0/v0.1.1 exist.Kept, deliberately
hubas a page kind and a column: Spinny's own concept (the/used-cars/SEO page; a car's location hub), not a leftover.product_parser.py"a sibling site answers with Akamai" and the tokopedia<title>note,smoke_test.pyMediaMarkt note,captcha_solver.pyfarfetch-scraper notes,.gitignorecraigslist note: sibling provenance."datadome"in the vendor marker list: generic vendor name.price-monitoringfits (cars have prices).Suite: 561 PASS, OK before and after (engine groups skipped, engines absent).
ci_checks.py --secret-check --help-check --sample-checkgreen.🤖 Generated with Claude Code