-
Notifications
You must be signed in to change notification settings - Fork 0
fingerprint_client: read the key from .env, like everything else does #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env_config.env_value("TWOCAPTCHA_KEY")is passed directly asdefault=, so it's evaluated eagerly the instantadd_argument()runs — beforeparse_args()ever sees argv. Sinceenv_value()(env_config.py#L144-L154) logs a warning whenever the value matches a.env.exampleplaceholder, this means:--helpinvocation logs the placeholder warning even though no key resolution is actually happening..envbut correctly passes--key sk_real...on the command line still gets the spurious "is still set to the placeholder... treating it as unset" warning, even though their explicit flag overrides the default and the placeholder is never actually used.The sibling
scraper_api_client.pyavoids this exact problem: it keepsdefault=os.environ.get("TWOCAPTCHA_KEY")(side-effect-free) and instead callsenv_config.apply(args, keys={"TWOCAPTCHA_KEY": "key", ...})afterparse_args()(scraper_api_client.py#L294-L298) —apply()only callsenv_value()if the destination is still falsy (env_config.py#L166-L173), so an explicit--keyshort-circuits before the placeholder check ever runs.Suggest following that same shape here: keep the default as a plain env read and defer the
env_value()/placeholder check to afterparse_args(), only applying it ifargs.keyis still unset.