chore(size): budget every published package, not just core (C2) - #49
Merged
Merged
Conversation
size-limit only guarded @baas/core, so bundle bloat in the adapters or migrate
(an accidental heavy import, a dep that should be external getting bundled) would
ship unnoticed. Add a min+brotli budget per published package, externalizing each
package's own deps/peers (@baas/core, @supabase/supabase-js, convex) so the budget
measures OUR code, not the provider SDK.
Current vs limit: migrate 1.46/2 kB, adapter-memory 2.03/2.75 kB, adapter-supabase
2.77/3.75 kB, adapter-convex 1.92/2.75 kB (~30-40% headroom: trips on bloat, not
on normal feature work). Enforced in the existing `size` CI job. Tripwire: lowering
a limit below the current size makes `pnpm size` exit non-zero ("exceeded by ...").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Roadmap C2 (size budgets).
size-limitonly guarded@baas/core, so bundle bloat in the adapters or@baas/migrate— an accidental heavy import, or a dep that should stay external getting bundled — would ship unnoticed.Adds a min+brotli budget per published package, externalizing each package's own deps/peers (
@baas/core,@supabase/supabase-js,convex) so the budget measures our code, not the provider SDK.~30-40% headroom: trips on bloat, not on normal feature work. Enforced by the existing
sizeCI job.Verification
pnpm sizepasses for all five.pnpm sizeexit 1 (Package size limit has exceeded by 1.77 kB).Config-only (
.size-limit.json); nosrcchange, no changeset.