Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Certes/Acme/Resource/Account.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,13 @@ internal class Payload : Account
/// <value>
/// The only return existing flag.
/// </value>
// Must be public for the source generator to emit it — see the note on
// Order.Payload.Csr. An internal setter would be silently dropped, breaking
// the "return existing account" lookup. Payload is internal, so the public
// accessor does not widen the API surface.
[JsonPropertyName("onlyReturnExisting")]
internal bool? OnlyReturnExisting { get; set; }
[JsonInclude]
public bool? OnlyReturnExisting { get; set; }
}
}
}
8 changes: 7 additions & 1 deletion src/Certes/Acme/Resource/Order.cs
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,14 @@ internal class Payload : Order
/// <value>
/// The CSR.
/// </value>
// Must be public: System.Text.Json's source generator serializes only public
// members, so an internal Csr is silently dropped and finalize sends a payload
// with no csr — the server then fails with "asn1: syntax error: sequence
// truncated". The enclosing Payload class is internal, so this does not widen
// the public API surface.
[JsonPropertyName("csr")]
internal string Csr { get; set; }
[JsonInclude]
public string Csr { get; set; }
}
}
}
Loading