Repository navigation
test: migrate JSON-RPC calls from bitcoin-cli to the IPC Rpc interface - #47
Merged
Sjors merged 1 commit intoOct 28, 2026
Merged
Conversation
Test helpers that performed JSON-RPC calls to the node did so through bitcoin-cli (`bitcoin rpc`), spawning a process per call. Send them through the IPC `Rpc.executeRpc` method instead, over the same Unix socket the tests already use. `cargo test` no longer needs `BITCOIN_BIN`. Drop it from `run-tests.sh` and the README.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test helpers that made JSON-RPC calls to the node did so via bitcoin-cli (
bitcoin rpc), spawning a process for each call. Send them through the IPCRpc.executeRpcmethod (introduced in #26) instead, over the same Unix socket the tests already use.cargo testno longer needsBITCOIN_BIN. Drop it fromrun-tests.shand update the README