Skip to content

test: migrate JSON-RPC calls from bitcoin-cli to the IPC Rpc interface - #47

Merged
Sjors merged 1 commit into
2140-dev:masterfrom
xyzconstant:make-rpc-calls-in-tests-over-ipc
Oct 28, 2026
Merged

Sjors merged 1 commit into
2140-dev:masterfrom
xyzconstant:make-rpc-calls-in-tests-over-ipc

Conversation

@xyzconstant

@xyzconstant xyzconstant commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Test helpers that made JSON-RPC calls to the node did so via bitcoin-cli (bitcoin rpc), spawning a process for each call. Send them through the IPC Rpc.executeRpc method (introduced in #26) instead, over the same Unix socket the tests already use.

cargo test no longer needs BITCOIN_BIN. Drop it from run-tests.sh and update the README

Test helpers that performed JSON-RPC calls to the node did so through
bitcoin-cli (`bitcoin rpc`), spawning a process per call. Send them
through the IPC `Rpc.executeRpc` method instead, over the same Unix
socket the tests already use.

`cargo test` no longer needs `BITCOIN_BIN`. Drop it from
`run-tests.sh` and the README.
@Sjors
Sjors merged commit 0eb52e5 into 2140-dev:master Oct 28, 2026
1 check passed
@Sjors

Sjors commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants