Repository navigation
contrib: run tests against a fresh datadir - #40
Merged
Merged
Conversation
Collaborator
|
Two minor suggestions from a friendly neighborhood LLM:
|
run-tests.sh started the node on the default datadir, so it reused whatever regtest state was already there and left its own behind. Start it on a fresh `/tmp/capnp-type-tests` instad, recreated on every run, and pass it to the tests as `BITCOIN_DATADIR`.
xyzconstant
force-pushed
the
fresh-datadir-for-tests
branch
from
September 28, 2026 15:20
0eb1b25 to
369245b
Compare
Contributor
Author
Done at 369245b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #33 based on #33 (review).