Skip to content

[doc] clarify slice write-back and conversion contracts (DOC-09) - #92

Merged
vt128 merged 1 commit into
masterfrom
codex/docs-starlight-api-followup-20261109
Nov 9, 2026
Merged

vt128 merged 1 commit into
masterfrom
codex/docs-starlight-api-followup-20261109

Conversation

@vt128

@vt128 vt128 commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Wrapped slice element updates can reach the host while append/clear operations change only the wrapper header. Result conversion also has non-error fallback behavior callers must distinguish from input-conversion failures. This update adds an explicit slice write-back example and documents result conversion, direct-key validation, method visibility, checked assignments and configured-root module lookup.

Three GoInterface godoc lines and two maintenance-guide statements are corrected. Original code fences remain. All 25 comment-free Go ASTs and compiler directives are identical to master; tests and module files are unchanged.

Validation: normal gofmt/vet/test commit hook passes. Fresh Go 1.27.3 / Go 1.19.13 baseline/candidate build, race-count=2 atomic coverage and vet pass; both profile pairs retain all 2126 blocks exactly, with no coverage decrease. Slice write-back and competing-root module lookup each pass once on both compilers with exact output and recorded binary dependencies.

All 14 code blocks across the 3 changed Markdown documents render completely in GitHub GFM, checked against their full source text.

Tracks DOC-09. No runtime implementation, dependency, Go-floor or interpreter change; no new performance benchmark.

@codacy-production

codacy-production Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (39602ed) 2216 2017 91.02%
Head commit (7ae66d2) 2216 (+0) 2017 (+0) 91.02% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#92) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.72%. Comparing base (39602ed) to head (7ae66d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files           8        8           
  Lines        1718     1718           
=======================================
  Hits         1593     1593           
  Misses        124      124           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vt128
vt128 marked this pull request as ready for review November 9, 2026 12:15
@vt128
vt128 force-pushed the codex/docs-starlight-api-followup-20261109 branch from 9ae6899 to 7ae66d2 Compare November 9, 2026 17:38
@vt128
vt128 merged commit 59694c4 into master Nov 9, 2026
14 checks passed
@vt128
vt128 deleted the codex/docs-starlight-api-followup-20261109 branch November 9, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant