Skip to content

[fix] keep accepted pointer materialization panic-free (SLT-21) - #86

Closed
vt128 wants to merge 1 commit into
masterfrom
codex/fix-collection-pointers-20261107
Closed

vt128 wants to merge 1 commit into
masterfrom
codex/fix-collection-pointers-20261107

Conversation

@vt128

@vt128 vt128 commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Accepted collection elements such as nil scalar pointers could panic during indexing or iteration, and cyclic pointer/interface chains could expand indefinitely. Preserve the original Go value as an opaque GoInterface in APIs that cannot return errors, with cycle state confined to pointer/interface unwrapping. Static unsupported types remain rejected; host identity, method precedence and existing Starlark values are preserved. Fixes SLT-21.

The unchanged patch is replayed onto current master 59694c47. Fresh Go 1.27.3 and Go 1.19.13 build, race tests twice and vet pass. Statement coverage increases from 1276/1385 to 1296/1398 on both compilers, with no old covered hits lost; existing tests and module files are preserved.

Prior combined #86/#87 integration measurements retain a roughly 3.7–5.7% paired timing signal in one Call/4 KiB-print path. Its cause is unconfirmed; measured bytes and allocations remain 4192 B/op and 5 allocs/op. This disclosed cost is accepted under the updated safety-first, simple-implementation criterion; it is not evidence of performance equivalence, and no new timing samples were taken. Current full-downstream and final-head CI gates remain pending, so this PR stays Draft.

Superseded by combined collection-safety PR #94, merged as a7a2ede after all required checks, scoped safety-cost acceptance and downstream verification. This historical PR is closed without merging because its complete change is delivered by #94. Original source heads, performance measurements and earlier validation failures remain preserved.

@codacy-production

codacy-production Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 197 complexity · 24 duplication

Metric Results
Complexity 197
Duplication 24

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@vt128
vt128 changed the base branch from codex/macos15-retirement-20261107 to master November 7, 2026 07:05
@vt128
vt128 force-pushed the codex/fix-collection-pointers-20261107 branch from 2da39ac to 7076099 Compare November 7, 2026 08:45
@codecov

codecov Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.19%. Comparing base (cd5f885) to head (500a12c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   92.72%   93.19%   +0.47%     
==========================================
  Files           8        8              
  Lines        1718     1734      +16     
==========================================
+ Hits         1593     1616      +23     
+ Misses        124      117       -7     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vt128
vt128 marked this pull request as ready for review November 7, 2026 08:57
@vt128
vt128 marked this pull request as draft November 7, 2026 09:37
@vt128
vt128 force-pushed the codex/fix-collection-pointers-20261107 branch 2 times, most recently from 0d309e9 to 500a12c Compare November 9, 2026 15:08
@vt128
vt128 force-pushed the codex/fix-collection-pointers-20261107 branch from 500a12c to b7c0f45 Compare November 10, 2026 03:27
@vt128 vt128 closed this Nov 10, 2026
@vt128 vt128 reopened this Nov 10, 2026
@vt128 vt128 closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant