Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 197 |
| Duplication | 24 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This was referenced Nov 6, 2026
vt128
changed the base branch from
codex/macos15-retirement-20261107
to
master
November 7, 2026 07:05
vt128
force-pushed
the
codex/fix-collection-pointers-20261107
branch
from
November 7, 2026 08:45
2da39ac to
7076099
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 92.72% 93.19% +0.47%
==========================================
Files 8 8
Lines 1718 1734 +16
==========================================
+ Hits 1593 1616 +23
+ Misses 124 117 -7
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vt128
marked this pull request as ready for review
November 7, 2026 08:57
vt128
marked this pull request as draft
November 7, 2026 09:37
vt128
force-pushed
the
codex/fix-collection-pointers-20261107
branch
2 times, most recently
from
November 9, 2026 15:08
0d309e9 to
500a12c
Compare
vt128
force-pushed
the
codex/fix-collection-pointers-20261107
branch
from
November 10, 2026 03:27
500a12c to
b7c0f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted collection elements such as nil scalar pointers could panic during indexing or iteration, and cyclic pointer/interface chains could expand indefinitely. Preserve the original Go value as an opaque
GoInterfacein APIs that cannot return errors, with cycle state confined to pointer/interface unwrapping. Static unsupported types remain rejected; host identity, method precedence and existing Starlark values are preserved. Fixes SLT-21.The unchanged patch is replayed onto current master
59694c47. Fresh Go 1.27.3 and Go 1.19.13 build, race tests twice and vet pass. Statement coverage increases from 1276/1385 to 1296/1398 on both compilers, with no old covered hits lost; existing tests and module files are preserved.Prior combined #86/#87 integration measurements retain a roughly 3.7–5.7% paired timing signal in one Call/4 KiB-print path. Its cause is unconfirmed; measured bytes and allocations remain 4192 B/op and 5 allocs/op. This disclosed cost is accepted under the updated safety-first, simple-implementation criterion; it is not evidence of performance equivalence, and no new timing samples were taken. Current full-downstream and final-head CI gates remain pending, so this PR stays Draft.
Superseded by combined collection-safety PR #94, merged as a7a2ede after all required checks, scoped safety-cost acceptance and downstream verification. This historical PR is closed without merging because its complete change is delivered by #94. Original source heads, performance measurements and earlier validation failures remain preserved.