Skip to content

[doc] Explain shared dictionary output synchronization - #203

Merged
vt128 merged 1 commit into
masterfrom
codex/docs-shared-output-workaround-20261115
Nov 14, 2026
Merged

vt128 merged 1 commit into
masterfrom
codex/docs-shared-output-workaround-20261115

Conversation

@vt128

@vt128 vt128 commented Nov 14, 2026

Copy link
Copy Markdown
Member

Document how Go hosts can safely use legacy shared-value output: one owner, or one application mutex covering every access to the mutable graph, including nested aliases and whole Machine calls. Include a complete Go example and explain callback limits. Narrow the ToJSON cycle guarantee to native Starlark containers.

Add a concurrent regression test that checks consistent root and nested-list values through both String and direct Go ToJSON. This verifies caller synchronization; these methods retain their existing behavior and still require it.

Validation:

  • Go 1.27.4 and Go 1.19.13: baseline and candidate full race suites (-count=2), build and vet pass.
  • The complete Go documentation example runs with both compilers.
  • Same-compiler coverage has no lost covered blocks. Production functions, layout, directives and module files are unchanged.

@codacy-production

codacy-production Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 23 minor

Results:
23 new issues

Category Results
CodeStyle 23 minor

View in Codacy

🟢 Metrics 13 complexity · 0 duplication

Metric Results
Complexity 13
Duplication 0

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (74c6925) 8530 8117 95.16%
Head commit (2a85e88) 8530 (+0) 8117 (+0) 95.16% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#203) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.05%. Comparing base (74c6925) to head (2a85e88).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          53       53           
  Lines        6834     6834           
=======================================
  Hits         6428     6428           
  Misses        258      258           
  Partials      148      148           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vt128
vt128 merged commit cfeb889 into master Nov 14, 2026
24 checks passed
@vt128
vt128 deleted the codex/docs-shared-output-workaround-20261115 branch November 14, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant