Skip to content

[chore] adopt released foundation patches (STAR-104) - #37

Merged
vt128 merged 1 commit into
masterfrom
codex/adopt-foundation-patches
Sep 23, 2026
Merged

vt128 merged 1 commit into
masterfrom
codex/adopt-foundation-patches

Conversation

@vt128

@vt128 vt128 commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Summary

Adopt the published starlet v0.2.4 and starlight v0.2.2 patches for STAR-104. This lets the host runtime consume the validated conversion-cache and runner fixes using real module tags.

Only these two selected module versions and their checksums change. Keep Go 1.19, the established go.starlark.net v0.0.0-20260324133313-ffb3f39dd27a pin, and all other selected dependencies unchanged. The documented host-reviewed source boundary still applies.

Validation

  • Local build, full race tests (-count=2), vet, and formatting checks passed.
  • Offline Linux amd64 Go 1.19 build, full race tests (-count=2), and vet passed.
  • Compared the complete selected module graphs: exactly the two intended version changes, with no replacement directives or floor changes.
  • A fresh CLI checkout was tested on the same source SHA in baseline and upgrade legs. Both the CLI and its nested examples module passed offline Go 1.25.8 build, race tests, and vet in both legs (four module-leg checks). The CLI end-to-end suite builds and executes the real binary. Both module floors and the interpreter pin remain unchanged.
  • All reported CI, Codecov Project/Patch, and reviewer findings will be verified before merge.

@codacy-production

codacy-production Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ca25bbd) 1177 1168 99.24%
Head commit (cf03eba) 1177 (+0) 1168 (+0) 99.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#37) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (ca25bbd) to head (cf03eba).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          12       12           
  Lines         879      879           
=======================================
  Hits          870      870           
  Misses          5        5           
  Partials        4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vt128
vt128 merged commit 78e6729 into master Sep 23, 2026
12 checks passed
@vt128
vt128 deleted the codex/adopt-foundation-patches branch September 23, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant