You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
打包 macOS 应用实际导入本机 IDEA 和 VS Code 配置,验证断点、定义、引用、查找、转到行、终端打开/关闭、Ctrl+D,以及 F5 启动和继续调试;验证重启持久化、撤销和来源变化后的保护;变基后的提交版再次导入本机 VS Code 并验证 Ctrl+G,1,433 个包文件运行前后哈希一致;此前验收包还验证了旧版 IDEA 的 Ctrl+F、Ctrl+F8,以及 VS Code 的条件移除不会误删 Command+S。
IDE 设置一键导入目前为 macOS 功能;Windows 已验证共享 Core,不声称 Windows 已提供同等导入界面。
提交后自审
按仓库 lithe-code-review 覆盖导入语义、快捷键冲突、插件信任、受限快照及生命周期、跨平台契约与测试。已修复审查中发现的旧版 IDEA 继承键位遗漏和 VS Code 条件移除误删问题;首轮 CI 的插件包验证器兼容问题已修复并复测;Windows 测试路径问题的上游修复已纳入分支;未发现需要阻塞合并的代码问题。日志窗口逐项查看、其他 IDE 扩展和键盘布局不在本次实机覆盖内。
条件不足,未验证:Allow the imported terminal toggle through the focused terminal while preserving other plain Control chords. Baseline MacShortcutDetector defers every plain Control chord before matching commands; head makes an exception for the matched toggle-terminal command.
Requires macOS, an interactive desktop and exact-revision Lithe applications using isolated application data. Headless Windows cannot exercise AppKit event dispatch, terminal focus or shell input.
条件不足,未验证:Import IDEA/VS Code reference bindings and supported overrides through the shipped provider; preserve removal semantics, source selection, stale-preview protection, persistence and undo. Include the review's initially missing source-file case, which cannot be established by Core-only validation.
The production import workflow, source snapshots and persistence adapters are macOS Swift/Darwin code. No macOS runtime, desktop, packaged application or isolated application-data configuration is supplied. The asynchronous source-creation case also needs a controlled provider pause at the snapshot-read boundary.
条件不足,未验证:Validate the shared import/conflict/source-plan contracts and state-dependent F5 decision exposed by keymap.decodeImport, keymap.planImportBindings, keymap.planImportSources and debug.startOrContinue.
Cargo and rustc are inventoried, but no Windows C compiler/linker or SDK is supplied. The production Core dependency graph includes native C compilation through tree-sitter/ring. No exact-revision prebuilt Core library is supplied either. Provide the native build prerequisites before freezing an executable probe; dependency installation must stay inside the checkout.
未覆盖:
The focused-terminal toggle and shell-input requirements remain unverified because their scenario requires an interactive macOS application.
Actual IDEA/VS Code parsing, reference defaults, inheritance, override ordering, removal rules, conditional rules, chords and extension handling remain unverified.
Native execution of imported find/replace, next/previous match, go-to-line, definition, implementation, references, command search, breakpoint and run/debug shortcuts remains uncovered. Language navigation and real F5 start/continue additionally require production language/debug adapters and a deterministic project fixture; Java is unavailable.
The shared Core contract scenario is blocked. Its proposed cases also do not exhaust every byte/count budget, malformed payload, duplicate entry, modifier combination and native key representability boundary.
Native conflict presentation, settings revision protection, persistence, restart, undo and preservation of unrelated custom bindings remain unverified.
Stale-source rejection remains unverified, including creation of initially absent files and directory membership changes during an outstanding provider request.
Official package verifier acceptance of trusted non-language plugins and rejection of missing backends, undeclared native code, unsafe paths and mismatched trust policies has no selected executable scenario. It requires the macOS Swift verifier and controlled package fixtures.
Actual structured failure/warning log files and absence of source contents or local paths remain unverified. Log-window presentation and localization also require desktop acceptance.
Installed-package byte immutability across startup, import, terminal and debug workflows remains unverified.
Node, Rust and Java SDK compatibility with old/new hosts, public contract synchronization, parser-test CI integration and the review's stale documentation concerns remain uncovered; no external repository or CI service was contacted.
Memory, input latency and terminal-key latency comparisons remain uncovered. Performance acceptance needs a prespecified statistical protocol and suitable instrumentation; two functional repetitions cannot establish it.
Other IDE versions, profiles, extensions, keyboard layouts and visual/focus behavior remain uncovered. Windows import UI parity is explicitly outside this PR's stated scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review: highghfind author score; see https://ghfind.com
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
用户可见改动
验证
依赖与范围
提交后自审
按仓库
lithe-code-review覆盖导入语义、快捷键冲突、插件信任、受限快照及生命周期、跨平台契约与测试。已修复审查中发现的旧版 IDEA 继承键位遗漏和 VS Code 条件移除误删问题;首轮 CI 的插件包验证器兼容问题已修复并复测;Windows 测试路径问题的上游修复已纳入分支;未发现需要阻塞合并的代码问题。日志窗口逐项查看、其他 IDE 扩展和键盘布局不在本次实机覆盖内。