Repository navigation
fix(macos): 补齐分支滚动隐藏层点击转发与关闭清理 (#1621) - #1629
Merged
Merged
Conversation
xiaoyumuxi
marked this pull request as ready for review
October 31, 2026 15:58
Lithe Review结论: 未发现需要阻塞合并的问题。 Scope Check
Suggestions
Summary事件转发与清理职责集中,弱引用和独立关闭监听符合展开层脱离旧行后的生命周期。新增测试使用注入调度器,覆盖主要边界;组件事件测试仍不能替代完整产品交互验收。 Verification
|
Collaborator
Author
|
#1625 修复这个PR的没有修复的地方 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Follow-up to #1625,关联 #1621。原 PR 已合入
preview;本 PR 从合入后的d5e47e17a新建分支,不回退原有触控板滚动修复。原实现用透明展开面板继续接收触控板手势,但有两个边界:
修改
NSApp.sendEvent交给当前命中控件;保留事件类型、时间戳、修饰键、点击次数、事件编号和压力。pending。自动化验证
使用 Swift 6.3.3;本机默认 macOS 27.2 SDK 与该编译器不兼容,仅为验证命令设置
SDKROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX26.5.sdk,未修改仓库或全局工具链配置。BranchSwitcherPopoverBehaviorTests、GitSavedChangesRowTests、LitheTreeListTests、ContextMenuCoverageTests、LitheActionMenuFocusTests、AgentSkillsAppearanceTests及其匹配的列表回归。ci-macos.yml相同过滤范围的 Swift 单元测试:3562 个测试、424 个 suite 全部通过(111.404 秒),无新增跳过或放宽门禁。git diff --check全部通过。.artifacts/platform-feature-matrix/视图与本地测试 HTML/JUnit/JSON(pr1621-followup-*),不提交产物。本机验证中的波动
前一轮曾出现原生菜单焦点断言失败,完整测试随后因 120 秒无输出被看门狗终止;采样显示 AppKit 的
NSAnimationworker 耗尽,不能从最后一行输出归因于某个测试。未改的preview定向对照 36 个测试通过;恢复修复后的最终定向 71 个及完整 3562 个测试也全部通过。保留这些失败日志,不将一次重跑通过等同于证明已有测试完全稳定。未验证/交付边界
/Applications/Lithe.app,未关闭用户实例。