Repository navigation
feat(macos): 补齐全局编辑器样式与 VS Code/IDEA 语法配色 - #1568
Merged
Merged
Conversation
arkleselect
requested review from
1lck,
Mucheen and
xiaoyumuxi
as code owners
October 29, 2026 04:23
Lithe Review结论: 未发现需要阻塞合并的问题。 Scope Check
Suggestions
Summary改动沿用现有设置存储和编辑器更新路径,新增选项通过 Verification
|
xiaoyumuxi
reviewed
Oct 29, 2026
xiaoyumuxi
left a comment
Collaborator
There was a problem hiding this comment.
Review 结论
建议修改 1 项 P2;未发现需要阻塞合并的问题。具体问题见行内评论。
审查范围:43a31d4b → c79a09b2。已检查设置持久化、Swift→Monaco 配置链路、主题与新增测试;i18n、运行时 bundle 只读边界、编辑器/Windows 架构边界、平台功能矩阵、Agent Notes 和针对本次提交范围的测试稳定性静态检查通过。使用现有 Monaco 渲染器的最小 Node 探针确认:关闭行号后断点元素输出为空。
未启动 Lithe,未重跑完整 Swift、WebKit 或 Windows 测试;上述静态检查和探针不替代原生运行时验收。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动
macOS 编辑器此前只暴露部分外观选项,源码高亮固定使用内置色表。本次在「设置 → 编辑器」补齐所有项目共享的样式配置,修改后即时作用于已有及新建源码视图,并持久化保存。
范围
作用于 macOS 主源码编辑器、分栏、独立文件窗口和完整源码预览。原生 Diff、SQL 控制台、终端与结果片段沿用各自排版。本次不实现 VS Code/IDEA 检测或配置导入,也不包含 Java Support 导航增强。配色按现有词法/语义角色映射,不承诺完整复现上游所有语言规则。
已同步 1lck/Lithe-IDEA preview
48c27485c,保留全局样式及硬链接保存功能的翻译词条。验证
此前在基线
21e03f704做过完整 Swift 对照:改动版与干净基线均出现相同的 4 个失败测试(Git 日期筛选、Native Diff 额外行配对、Diff 标题布局、Git graph 悬停)。未将全量测试标为通过,也未夹带修复无关基线问题;同步最新 preview 后重新执行受影响的针对性测试。完整产品的多项目、重启及全部设置布局验收,和 Windows WebView2 原生验收仍待完成,功能矩阵保留 pending。测试启动的探针按生命周期退出。
合入 preview 后的 CI 修复
文件访问层已将符号链接错误细分为
DocumentFileAccessError.symbolicLink,Agent 文件回滚测试仍期待旧的CocoaError,导致 Swift CI 唯一失败。更新该测试为精确匹配符号链接错误,保留链接恢复、目标内容不变和临时路径清理的全部断言。验证:Swift 6.3.3 下 AgentEditRestorerTests、DocumentHardLinkTests、DocumentOpenAndHardLinkWorkflowTests 共 41 项通过;测试稳定性、功能矩阵及运行时 bundle 只读检查通过。