[1395490241lhj-code]

Summary

Fixes from two read-only reviews of the native iOS app (a new-user UX review and a functional-logic review, 2026-10-19). Every finding was re-checked against the code by an independent verifier before it was fixed. The review fixes are one commit per item, so any single fix can be reverted on its own. Later commits stabilise UI tests on CI and add the pre-merge fixes below. 60 commits in total.

No SwiftData schema change. Legacy data migration now runs only once (de14ffd), so emptied lists stay empty. No sync flag, Keychain, entitlement, backup-format, login, timer or background-behaviour change.

Batch 1: dead ends and data safety (5ff9eac..46821a2, 8 commits)

• AI 换一批 recipes are saved before being added to today; previously they couldn't be opened or cooked.
• Home recommendations recompute once the real recipe library loads. Before, they stayed stuck on the 2 samples for the whole day.
• Restock suggestions leave out the meal just cooked.
• The consumption sheet shows unit-mismatched stock honestly.
• Status staples flip back to in stock on stock-in.
• A new weekly AI menu starts from today.
• Special-plan delete and draft discard ask for confirmation, and the backup page warns that user recipes aren't included.

Batch 2: inventory deduction, reminders, data safety (829fdc2..cc1dd5a, 15 commits)

• Swipe-delete buttons are red (inventory, planner, AI history).
• Expiry reminders are no longer silently cancelled on every inventory change or cold start.
• Mixed-unit batches: cooking only deducts the batches that convert, so 1 盒 is no longer zeroed against a recipe in 个.
• Preset 葱姜蒜盐油 staples count as present.
• The per-dish shopping sheet no longer under-buys. This fixes a regression from df25377.
• A special-plan dish cooked from its recipe page deducts once.
• Cooked meals are ignored in Home 还缺.
• Recipe lines without an amount are judged by presence.
• Weighed seasonings are classified as seasonings.
• 添加常备食材 no longer overwrites another batch.
• AI 做菜's unsaved 仅加入今日计划 is removed.
• The weekly AI draft is persisted.
• AI read tools honour per-message context exclusions.
• The account-deletion page says what it clears.
• Plan, weekly-menu and special-plan save failures are surfaced, and an unreadable special-plan table is guarded.

Test and docs (723ebeb, aeafe7c)

• PlannerUITests.testCreateSpecialPlanFlowIsOneRequestPlusOneSwitch now accepts the draft-discard alert added in 46821a2.
• AGENTS.md/CLAUDE.md: shared Mac resource rules (owner's edit).

Batch 3: cooking, recipe editing, planning, AI logic (45a0e62..2a57c56, 20 commits)

• A library cook asks whether it is today's planned meal, which stops double deduction.
• Deductions scale by servings ÷ base yield.
• The edited recipe is shown after saving, so a second edit no longer overwrites the first.
• Ingredient rows stay stable while editing.
• Cooked dishes are kept when saving an AI special-plan menu.
• Legacy data migrates once, so emptied lists stay empty.
• Clearing ticked items says they are not stocked, and mark-all can be undone.
• Deleting a recipe warns how many plans use it.
• Edited 使用量 is written through.
• Used-up is judged per food across batches.
• Ticked rows count as bought and awaiting stock-in.
• Quantity ranges and 条/棵/瓣/枚/粒/朵 are parsed.
• The weekly menu's shopping goes through the shared review sheet.
• A weekly menu is never regenerated or copied onto past days.
• Unlabelled recipes are kept under the 难度/烹饪时间 filters.
• Kitchen AI accepts a serving count, each AI page reopens its own conversation safely, and the AI knows today's date and names the day on plan changes.
• A stuck shared link can be removed.
• Staple reminders are delivered and denied toggles are shown as off.

CI follow-ups (c9f3998..e23e6a2, 12 commits)

• UI-test stabilisation for CI (Xcode 26 / iOS 26), plus two fixes: an unplanned Planner day can be shorter than a planned meal (98cd920), and a completed meal shows its servings as text (fb2e567).

Pre-merge fixes (dd9ab14)

• A weekly menu whose start date has passed now asks before it is added (「菜单日期已过」). The prompt names the start date and the new days, with years when the dates span two years. Agreeing moves the whole draft to start today, with dishes and order kept.
  • Cancelling writes nothing.
  • The collision check still runs on the moved days.
  • A pending or finished receipt is never moved.
  • If saving the moved draft fails, no meal is written.
• Status-tracked staples (有货/快没了/缺货) are never deducted by cooking. Their quantity is a placeholder.
  • The consumption sheet shows them as present and says why.
  • With mixed stock, only the counted batches are deducted.
  • RecipeStockMatch and the D-050 undo contract are unchanged.
• DEBUG-only fixtures:
  • injectable "now" for planner UI tests;
  • seeds for a stuck share link and for the consumption sheet. The share seed stops with a reason instead of falling back to the App Group queue or standard defaults.
  • AccountLifecycleFixtureDeletionService, so the account UI-test fixture never reaches the backend. Its preview is canned and every later step refuses.
• Tests:
  • weekly stale-start unit tests (same day, days later, cancel, cross-week/month/year, DST, collision, persistence failure, pending/finished receipts, copy);
  • StatusStapleConsumptionTests;
  • a weekly stale-start UI test;
  • PR31VisualAcceptanceUITests, a reusable visual regression class over Light/Dark × Normal/AXXXL.

CI visual-test fixes (8a6e66e)

On CI (iOS 26.5), 3 of the 8 PR31VisualAcceptanceUITests failed in dispatch run 39611008239. The xcresult, activity timeline and screen recordings showed all three were faults in the tests, not in the app:

• Appearance. The "Dark" runs rendered light, because the simulator appearance alone does not reach the app before its first render. The tests now pass UITEST_FORCE_DARK_APPEARANCE / UITEST_FORCE_LIGHT_APPEARANCE, like the other screenshot suites. The Dark screenshots from run 39611008239 are therefore not valid evidence.
• Label queries. On iOS 26.5 a SwiftUI Label's identifier lands on its icon, which is never hittable. The recordings show the text fully on screen. Reachability is now judged on the label's text, and the identifier is only checked to still exist.
• Short toast. The 1.8s 「已移除这条分享」 toast did show (the recording confirms it), but it left the accessibility tree about 1.9s after the tap. The first check came at 2.19s. A DEBUG-only UITEST_LONG_FEEDBACK_TOAST now holds Home's toast for 20s, as UndoToastTiming does for 撤销. Release builds have no DEBUG condition, and debug builds without the argument, keep 1.8s.
• Local run of the full class on iOS 27.2: 8/8 passed.

CI visual-test fixes, part 2 (7514f3e)

Dispatch run 39637015717 on 8a6e66e passed 7 of 8. Its Dark screenshots are genuinely dark: mean luma 27–39, against 191+ for Light. testConsumptionSheetExplainsUnitsAndStatusStaples still failed at Light-AXXXL, for two more test faults:

• Lazy rows. The identifier was checked before scrolling. On iOS 26.5 an off-screen list row is not in the accessibility tree yet. revealLabel now scrolls to the label's text first, then checks the identifier. The reachability, identifier and full-text assertions are all kept.
• Locale order. The CI simulator runs in English, so localizedCompare sorted the rows 番茄, 葱, 鸡蛋. Scrolling down to 葱 left 番茄 above the screen. The visual tests now launch the app in its own zh-Hans / zh_CN, the order a member sees. Swiping back down was not used, because the sheet could be dismissed by it.
• Local run of the full class with -testLanguage en -testRegion US, to reproduce CI: 8/8 passed, with rows in 葱, 番茄, 鸡蛋 order.

Validation for dd9ab14

Local runs used the reserved simulator (iPhone 18 Pro / iOS 27.2) through dev-sim-slot with the xcodebuild fallback, because Xcode MCP was held by another worktree.

• Pre-fix negatives failed as expected.
  • Staples: 有货/快没了 葱 went from 1 to 0 and became unavailable.
  • Stale menu: 1 plan was written with no confirmation.
• Full unit target, before the last two copy/fixture edits: 2,619 run, 0 failures, 5 skipped (gated hosted-sync smoke tests).
• After those two edits:
  • WeeklyMenuMaterializationTests 51/51 and SharedImportQueueTests 15/15;
  • a temporary probe, not committed, confirmed that a refused defaults suite stops the share seed and writes no queue file;
  • the weekly stale-start UI test and the weekly + share-link visual cases passed.
• Focused UI:
  • WeeklyMenuMaterializationUITests 16/16 and PlannerWeeklyHostUITests 4/4;
  • PlannerUITests, RecipeCookingModeUITests and SpecialPlanMenuUITests: the affected cases passed.
• Visual acceptance: PR31VisualAcceptanceUITests covers 8 scenarios × 4 variants. All 78 screenshots were reviewed. Every new dialog is reachable with full text, and destructive actions are red.
• Targeted CI on the previous head e23e6a2 (run 39540334113): GuestMergeSummaryUI5B2BB2AUITests 21/21. It shows the earlier ui-full (2) failure was a CI flake. It is not evidence for dd9ab14.
• CI for dd9ab14:
  • iOS tests, push run 39599224175: success.
    • Unit target: 2,621 run, 0 failures, 5 skipped. This includes ConsumptionPersistenceTests 20/20 and KitchenStoreTests 49/49 (D-050), RecipePersistenceTests 13/13 and SwiftDataConsistencyTests 6/6 (de14ffd), StatusStapleConsumptionTests 7/7 and WeeklyMenuMaterializationTests 51/51.
    • Default UI set: 10 classes, 116 tests, 0 failures.
  • Node tests (Node 22 and 24) and iOS release config check: success.
  • Targeted PR31VisualAcceptanceUITests (dispatch run 39611008239): 3 of 8 failed. These were test faults, fixed in 8a6e66e (see above). Unit target 2,621 run, 0 failures.
• CI for 8a6e66e:
  • Push run 39619771774: success. Unit 2,621 run, 0 failures; default UI 116, 0 failures; Node 22/24 and release check: success.
  • Targeted visual dispatch 39637015717: 7 of 8 passed; the remaining test fault is fixed in 7514f3e.
• CI for 7514f3e (final head):
  • iOS tests, push run 39645705992: success. Unit target: 2,621 run, 0 failures, 5 skipped. This includes D-050 ConsumptionPersistenceTests 20/20 and KitchenStoreTests 49/49, and de14ffd RecipePersistenceTests 13/13 and SwiftDataConsistencyTests 6/6. Default UI set: 10 classes, 116 tests, 0 failures.
  • Node tests (Node 22 and 24) and iOS release config check: success.
  • Targeted PR31VisualAcceptanceUITests, dispatch run 39656183440 (iPhone 17 Pro, iOS 26.5): 8/8 passed. Unit target 2,621 run, 0 failures.
    • The run produced 76 screenshots: 19 states × 4 variants, none missing.
    • Dark screenshots: mean luma 11–54. Light: 191–244. Spot checks confirm the Dark variants really are dark.
    • The consumption sheet that failed before now shows its rows in 葱, 番茄, 鸡蛋 order, with full text at Light-AXXXL.

Earlier validation (before the first push, older tree)

• Unit suite: 2,599 run, 0 failures, 5 skipped. Node source guards: 1,979/1,979.
• UI regression (20 related classes, 249 tests): 248 passed, 1 failed. SpecialPlanMenuUITests.testReplacingAnOffScreenDishIsObservedByItsOwnRow fails the same way on the clean baseline 46821a2.

Not verified / known visual notes

• No physical-device pass beyond an owner smoke install of batch 1.
• CI runs Xcode 26.x / iOS 26.x, which is a different evidence class from the local iOS 27.2 runs.
• At AXXXL, system alerts scroll their body text. In the stale-menu prompt the new range is below the fold, and the third button of 清除已购买 needs scrolling inside the alert. This is standard alert behaviour.
• At AXXXL, the translucent toast lets the text behind it show through (shopping undo, removed share link). It needs a design decision and is not changed here.
• The consumption sheet's 「来自：…」 line truncates at AXXXL. That line is unchanged from main.

Known follow-ups (not in this PR)

• PR Kitchen AI Phase 1a: tonight recipe recommendations with deterministic kitchen facts #32 protocol conflict: this PR (8f94284) accepts plannedServings from Kitchen AI, while PR Kitchen AI Phase 1a: tonight recipe recommendations with deterministic kitchen facts #32 removes it from the server schema. Resolve when Kitchen AI Phase 1a: tonight recipe recommendations with deterministic kitchen facts #32 is integrated.
• Non-blocking review notes:
  • be89345 ignores the servings stepper;
  • 1afdac6 takes the upper end of a quantity range;
  • 6a56646 saves silently;
  • 4fceba8 may reclassify some seasonings.
• Shopping rows don't record which dish added them, and special-plan dishes don't record their source. Both need a model change.
• The dates Kitchen AI receives are still UTC.
• Owner decisions needed: lunch/dinner meal slots, carry-over of uncooked meals, deducting quick meals, caching the recipe library offline, and treating expired food as "use first".
• Canonical project notes (vault) are to be reconciled after merge.

🤖 Generated with Claude Code