Repository navigation
fix(dashboard): stop nesting block content inside a <p> in the cancel dialog - #203
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… dialog Radix renders `AlertDialogDescription` as a `<p>`, and this one held a `<div>` (the payout summary) and another `<p>` (the closing warning). That is invalid HTML: React flags it at runtime, and the browser's parser recovers by closing the paragraph early, which splits the element `aria-describedby` points at. `asChild` renders the description as the `<div>` it always needed to be, with the intro text moved into its own `<p>`. The whole block stays inside the description rather than moving out as a sibling, so the accessible description still covers all of it. Salvaged from #202, whose test and config work was superseded by #201 — this was the one change in it that nothing else carried. Dashboard suite stays at 38/38. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
0xdevcollins
force-pushed
the
fix/dialog-description-nesting
branch
from
August 9, 2026 19:15
2eb289d to
fa9b3df
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvaged from #202. That PR's test and config work was superseded by #201, which greened the dashboard suite a different way — but this one change had no equivalent anywhere, so it would have been lost when #202 closed.
Radix renders
AlertDialogDescriptionas a<p>. This one contained a<div>(the payout summary) and a second<p>(the closing warning). React flags the invalid nesting at runtime, and the browser's parser recovers by closing the paragraph early — which splits the elementaria-describedbypoints at, so a screen reader gets part of the description rather than all of it.asChildrenders it as the<div>it always needed to be, with the intro text in its own<p>. The block stays inside the description rather than moving out as a sibling, which is what keeps the accessible description covering all of it.Dashboard suite stays at 38/38. Typecheck and lint clean (0 errors).
Closes #202.