fix: Bound the number of storage slots in get_account requests#2284
Open
sergerad wants to merge 1 commit into
Open
fix: Bound the number of storage slots in get_account requests#2284sergerad wants to merge 1 commit into
get_account requests#2284sergerad wants to merge 1 commit into
Conversation
sergerad
changed the title
get_account requests
kkovaacs
approved these changes
Jun 25, 2026
kkovaacs
left a comment
kkovaacs
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me % the param name comment I've added.
| /// [`QueryParamStorageMapKeyTotalLimit`] and could be repeated without bound. | ||
| pub struct QueryParamStorageMapSlotLimit; | ||
| impl QueryParamLimiter for QueryParamStorageMapSlotLimit { | ||
| const PARAM_NAME: &str = "storage_map_slot"; |
Contributor
There was a problem hiding this comment.
Isn't this field called storage_maps in the Protobuf message? I think there's no storage_map_slot field at all.
We should probably review other field name references as well as I'm fairly sure those are outdated as wel... :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of the
get_accountRPC endpoint, callers can supply a list of storage map slots to fetch, which was previously unbounded. This PR caps that list atAccountStorage::MAX_NUM_STORAGE_SLOTS(and rejects duplicate slots) to bound per-request work.Changelog