fix: Stream finalized tip in Validator#2270
Closed
sergerad wants to merge 2 commits into
Closed
Conversation
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
Collaborator
There was a problem hiding this comment.
As mentioned offline, I don't think this is actually a problem.
We should perhaps document the intention here more strongly in both the protobuf schema, as well as in the operator documentation.
The validator is intended as a recovery mechanism to ensure we don't drop any data in case a sequencer crashes. In other words, this is only meant to be used when there is no active sequencer, and therefore no new blocks coming in.
We should definitely stream up to the latest block. Otherwise the new sequencer won't have it.
Collaborator
Author
|
Closed in favour of supporting redrive #2283. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Validator's signed tip can be overwritten. However, we stream the tip immediately on signing. This means that downstream may receive multiple different blocks for the same height. This is not actually a problem at this stage because the stream is only used for backup and the backup should perform an overwrite (idempotent). However, it might be worthwhile to differentiate between signed and finalized here for future features to be aware of.
Changelog