Repository navigation
Fix processInChunksByChunk to pass chunk index instead of item offset - #5
Merged
Merged
Conversation
The handler's index parameter was incorrectly receiving the cumulative item offset instead of the zero-based chunk index as documented.
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in processInChunksByChunk where the index parameter passed to the handler callback was incorrectly providing the cumulative item offset instead of the zero-based chunk index as documented in the README.
- Removed the
overallIndexvariable that was tracking cumulative item position - Changed the callback to receive the chunk index directly from
chunks.entries() - Added a test to verify chunk indices are correctly passed as 0, 1, 2, etc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/process-in-chunks.ts | Removes overallIndex tracking and passes the chunk index from chunks.entries() to the callback, fixing the mismatch between documented and actual behavior |
| src/process-in-chunks.test.ts | Adds test case to verify that chunk indices (0, 1, 2) are correctly passed to the callback function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
indexparameter passed to theprocessInChunksByChunkhandler was incorrectly receiving the cumulative item offset instead of the zero-based chunk index as documented in the README.This fix ensures the handler receives the chunk index (0, 1, 2, ...) matching the documented behavior.