Repository navigation
Fail clearly when pnpm patch hashes are missing - #214
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The fail-fast behavior is correctly implemented with comprehensive regression coverage.
Pull request overview
Adds fail-fast pnpm patch-hash validation to prevent invalid isolated lockfiles, resolving #212.
Changes:
- Rejects missing or unreadable patch hashes across supported pnpm versions.
- Adds pnpm 8–11 coverage and resets reader mocks between tests.
File summaries
| File | Description |
|---|---|
src/lib/patches/copy-patches.ts |
Validates hashes before copying patch files. |
src/lib/patches/copy-patches.test.ts |
Covers reader formats and failure paths. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reachable patch without a matching pnpm lockfile hash used to produce
hash: ""under pnpm 9 and 10. pnpm rejected the isolate later, during install.copyPatchesnow aborts before copying a patch if any supported pnpm reader cannot supply its hash. Tests cover pnpm 8's object entries, pnpm 9 and 10's string entries, and unreadable lockfiles across pnpm 8 through 11. The test setup restores default reader mocks for each case.Decisions:
Closes #212
Scope: packages (isolate-package)
Visibility: user-facing
Implementer: codex:gpt-5.6-terra:xhigh