finally enable eslint on typescript plugin codebase and do 300 fixes

Author: zardoy

.eslintignore

@@ -1,5 +1,3 @@
-# ignore files that have typescript import
-typescript/**
 src/configurationType.ts
 src/configurationTypeCache.jsonc
 playground.ts

.eslintrc.json

@@ -1,6 +1,45 @@
 {
     "extends": "zardoy",
     "rules": {
-        "curly": "off"
-    }
+        "curly": "off",
+        "import/no-deprecated": "off",
+        // investigate why it is soooo slow...
+        "import/no-named-as-default": "off",
+        "import/no-named-as-default-member": "off",
+        "default-case": "off",
+        "sonarjs/no-duplicate-string": "off",
+        "@typescript-eslint/naming-convention": "off",
+        "no-empty-function": "off",
+        "no-useless-return": "off",
+        "no-template-curly-in-string": "off"
+    },
+    "overrides": [
+        {
+            "files": "typescript/**",
+            "parserOptions": {
+                "project": "typescript/tsconfig.json"
+            },
+            "rules": {
+                "@typescript-eslint/padding-line-between-statements": "off",
+                "arrow-body-style": "off",
+                "import/no-extraneous-dependencies": "off",
+                "@typescript-eslint/no-loop-func": "off",
+                // always used intentionally as workaround for possibly undefined types (to not declare super complex types - cases)
+                "@typescript-eslint/no-unnecessary-boolean-literal-compare": "off",
+                // todo configure instead
+                "complexity": "off",
+                "max-params": "off",
+                "max-depth": "off",
+                "@typescript-eslint/dot-notation": "off",
+                "no-bitwise": "off",
+                "@typescript-eslint/no-explicit-any": "off",
+                // todo just not sure
+                "@typescript-eslint/prefer-regexp-exec": "off",
+                "unicorn/consistent-destructuring": "off",
+                "no-negated-condition": "off",
+                "@typescript-eslint/prefer-nullish-coalescing": "off",
+                "unicorn/prefer-set-has": "off"
+            }
+        }
+    ]
 }

typescript/src/adjustAutoImports.ts

@@ -88,7 +88,7 @@ export const findIndexOfAutoImportSpec = (ignoreAutoImportsSetting: ParsedIgnore
         if (!symbols.includes(symbol)) continue
         return i
     }
-    return
+    return undefined
 }
 
 export const shouldChangeSortingOfAutoImport = (symbolName: string, c: GetConfig) => {
@@ -98,7 +98,7 @@ export const shouldChangeSortingOfAutoImport = (symbolName: string, c: GetConfig
 
 export const changeSortingOfAutoImport = (c: GetConfig, symbolName: string): ((module: string) => number) => {
     const arr = c('autoImport.changeSorting')[symbolName]
-    if (!arr || !arr.length) return () => 0
+    if (!arr || arr.length === 0) return () => 0
     const maxIndex = arr.length
     return module => {
         let actualIndex = arr.findIndex(x => {

typescript/src/codeActions/custom/changeStringReplaceToRegex.ts

@@ -1,5 +1,5 @@
-import { CodeAction } from '../getCodeActions'
 import escapeStringRegexp from 'escape-string-regexp'
+import { CodeAction } from '../getCodeActions'
 import { getChangesTracker } from '../../utils'
 
 export default {

typescript/src/codeActions/custom/objectSwapKeysAndValues.ts

@@ -42,18 +42,20 @@ export default {
             if (!name || ts.isPrivateIdentifier(name)) continue
             const initializerText = printNodeForObjectKey(initializer)
             if (!initializerText) continue
-            edits.push({
-                newText: initializerText,
-                span: nodeToSpan(name),
-            })
-            edits.push({
-                newText: ts.isComputedPropertyName(name)
-                    ? name.expression.getText()
-                    : ts.isIdentifier(name)
-                    ? /* TODO quote preference */ `'${name.text}'`
-                    : name.getText(),
-                span: nodeToSpan(initializer),
-            })
+            edits.push(
+                {
+                    newText: initializerText,
+                    span: nodeToSpan(name),
+                },
+                {
+                    newText: ts.isComputedPropertyName(name)
+                        ? name.expression.getText()
+                        : ts.isIdentifier(name)
+                        ? /* TODO quote preference */ `'${name.text}'`
+                        : name.getText(),
+                    span: nodeToSpan(initializer),
+                },
+            )
         }
         return {
             edits: [

typescript/src/codeActions/custom/toggleBraces.ts

@@ -31,7 +31,6 @@ const tryToApply: ApplyCodeAction = (sourceFile, pos, range) => {
             { start: wrapNode.getEnd(), length: 0, newText: `\n${startIndent}}` },
         ]
     }
-    return
 }
 
 export default {

typescript/src/codeActions/decorateProxy.ts

@@ -12,7 +12,7 @@ export default (proxy: ts.LanguageService, languageService: ts.LanguageService,
         previousGetCodeActionsResult.value = compact(
             prior.flatMap(refactor => {
                 const actions = refactor.actions.filter(action => !action.notApplicableReason).map(action => action.description)
-                if (!actions.length) return
+                if (actions.length === 0) return
                 return actions.map(action => ({ description: refactor.description, name: action }))
             }),
         )

typescript/src/codeActions/extended/addMissingProperties.ts

@@ -16,7 +16,7 @@ export default {
             }
             // general patterns
             if (param.type && ts.isTypeLiteralNode(param.type) && param.type.members) {
-                const hasMembers = param.type.members.length !== 0
+                const hasMembers = param.type.members.length > 0
                 const insertPos = param.type.members.at(-1)?.end ?? param.type.end - 1
                 const insertComma = hasMembers && sourceFile.getFullText().slice(insertPos - 1, insertPos) !== ','
                 let insertText = node.text
@@ -44,6 +44,5 @@ export default {
                 }
             }
         }
-        return
     },
 } as ExtendedCodeAction

typescript/src/codeActions/functionExtractors.ts

@@ -120,7 +120,7 @@ export const handleFunctionRefactorEdits = (
                     },
                     {
                         span: functionChange.span,
-                        newText: oldFunctionText.match(/\s*/)![0] + newFunctionSignature.slice(0, -2) + '\n' + lines.slice(1).join('\n'),
+                        newText: `${oldFunctionText.match(/\s*/)![0] + newFunctionSignature.slice(0, -2)}\n${lines.slice(1).join('\n')}`,
                     },
                 ],
             },
@@ -137,7 +137,7 @@ export const handleFunctionRefactorEdits = (
     functionChange.newText = oldFunctionText
         .replace(/function /, 'const ')
         .replace('(', ' = (')
-        .replace(/\{\n/, '=> {\n')
+        .replace(/{\n/, '=> {\n')
 
     const isLocal = actionName.endsWith('_local_arrow')
     // to think: maybe reuse ts getNodeToInsertPropertyBefore instead?
@@ -150,7 +150,7 @@ export const handleFunctionRefactorEdits = (
         functionChange.span.start = constantAdd.span.start
         const indent = constantAdd.newText.match(/^\s*/)![0]
         // fix indent
-        functionChange.newText = dedentString(functionChange.newText, indent, true) + '\n'
+        functionChange.newText = `${dedentString(functionChange.newText, indent, true)}\n`
     }
 
     // global scope

typescript/src/codeActions/getCodeActions.ts

@@ -1,11 +1,11 @@
 import { compact } from '@zardoy/utils'
+import { Except } from 'type-fest'
 import { findChildContainingExactPosition, findChildContainingPosition } from '../utils'
+import { ApplyExtendedCodeActionResult, IpcExtendedCodeAction } from '../ipcTypes'
 import objectSwapKeysAndValues from './custom/objectSwapKeysAndValues'
 import changeStringReplaceToRegex from './custom/changeStringReplaceToRegex'
 import splitDeclarationAndInitialization from './custom/splitDeclarationAndInitialization'
 import addMissingProperties from './extended/addMissingProperties'
-import { ApplyExtendedCodeActionResult, IpcExtendedCodeAction } from '../ipcTypes'
-import { Except } from 'type-fest'
 
 const codeActions: CodeAction[] = [objectSwapKeysAndValues, changeStringReplaceToRegex, splitDeclarationAndInitialization]
 const extendedCodeActions: ExtendedCodeAction[] = [addMissingProperties]
@@ -83,7 +83,7 @@ export const getExtendedCodeActions = <T extends string | undefined>(
         sourceFile,
     }
     if (applyCodeActionTitle) {
-        const codeAction = extendedCodeActions.find(codeAction => codeAction.title === applyCodeActionTitle) as ExtendedCodeAction | undefined
+        const codeAction = extendedCodeActions.find(codeAction => codeAction.title === applyCodeActionTitle)
         return codeAction!.tryToApply(tryToApplyOptions) as T extends undefined ? never : ApplyExtendedCodeActionResult
     }
     return compact(
@@ -144,7 +144,7 @@ export default (
     const requestingEdit: any = requestingEditsId ? appliableCodeActions.find(({ id }) => id === requestingEditsId) : null
     return {
         info:
-            (appliableCodeActions.length && {
+            (appliableCodeActions.length > 0 && {
                 actions: appliableCodeActions.map(({ id, name, kind }) => ({
                     description: name,
                     kind,