fix: improve a bit Volar takeover mode support

Author: zardoy

src/extension.ts

@@ -1,8 +1,9 @@
 /* eslint-disable @typescript-eslint/no-require-imports */
 import * as vscode from 'vscode'
 import { defaultJsSupersetLangs } from '@zardoy/vscode-utils/build/langs'
-import { extensionCtx, getExtensionSettingId } from 'vscode-framework'
+import { extensionCtx, getExtensionSetting, getExtensionSettingId } from 'vscode-framework'
 import { pickObj } from '@zardoy/utils'
+import { watchExtensionSettings } from '@zardoy/vscode-utils/build/settings'
 import { Configuration } from './configurationType'
 import webImports from './webImports'
 import { sendCommand } from './sendCommand'
@@ -15,10 +16,16 @@ import specialCommands from './specialCommands'
 import vueVolarSupport from './vueVolarSupport'
 import moreCompletions from './moreCompletions'
 
-export const activateTsPlugin = (tsApi: { configurePlugin; onCompletionAccepted }) => {
+let isActivated = false
+// let erroredStatusBarItem: vscode.StatusBarItem | undefined
+
+export const activateTsPlugin = (tsApi: { configurePlugin; onCompletionAccepted } | undefined) => {
+    if (isActivated) return
+    isActivated = true
     let webWaitingForConfigSync = false
 
     const syncConfig = () => {
+        if (!tsApi) return
         console.log('sending configure request for typescript-essential-plugins')
         const config = vscode.workspace.getConfiguration().get(process.env.IDS_PREFIX!)
 
@@ -48,7 +55,7 @@ export const activateTsPlugin = (tsApi: { configurePlugin; onCompletionAccepted
     })
     syncConfig()
 
-    onCompletionAccepted(tsApi)
+    if (tsApi) onCompletionAccepted(tsApi)
 
     if (process.env.PLATFORM === 'web') {
         const possiblySyncConfig = async () => {
@@ -79,24 +86,47 @@ export const activate = async () => {
 
     const possiblyActivateTsPlugin = async () => {
         const tsExtension = vscode.extensions.getExtension('vscode.typescript-language-features')
-        if (!tsExtension) return
+        if (tsExtension) {
+            await tsExtension.activate()
+
+            if (!tsExtension.exports || !tsExtension.exports.getAPI) {
+                throw new Error("TS extension doesn't export API")
+            }
+
+            // Get the API from the TS extension
+            const api = tsExtension.exports.getAPI(0)
+            if (!api) {
+                throw new Error("TS extension doesn't have API")
+            }
 
-        await tsExtension.activate()
+            activateTsPlugin(api)
+            return true
+        }
 
-        if (!tsExtension.exports || !tsExtension.exports.getAPI) return
+        if (vscode.extensions.getExtension('Vue.volar') && getExtensionSetting('enableVueSupport')) {
+            activateTsPlugin(undefined)
+            return true
+        }
 
-        // Get the API from the TS extension
-        const api = tsExtension.exports.getAPI(0)
-        if (!api) return
-        activateTsPlugin(api)
-        return true
+        return false
     }
 
     const isActivated = (await possiblyActivateTsPlugin()) ?? false
     if (!isActivated) {
-        // can be also used in future, for now only when activating TS extension manually
-        const { dispose } = vscode.extensions.onDidChange(async () => {
-            if (await possiblyActivateTsPlugin()) dispose()
+        // can be also used in future, for now only when activating TS or Volar extension manually
+        const disposables = []
+        const { dispose } = vscode.extensions.onDidChange(
+            async () => {
+                if (await possiblyActivateTsPlugin()) dispose()
+            },
+            undefined,
+            disposables,
+        )
+        watchExtensionSettings(['enableVueSupport'], async () => {
+            if (await possiblyActivateTsPlugin()) {
+                // todo
+                // disposables.forEach(d => d.dispose())
+            }
         })
     }
 }

src/sendCommand.ts

@@ -1,7 +1,7 @@
 import * as vscode from 'vscode'
 import { getActiveRegularEditor } from '@zardoy/vscode-utils'
 import { getExtensionSetting } from 'vscode-framework'
-import { TriggerCharacterCommand } from '../typescript/src/ipcTypes'
+import { passthroughExposedApiCommands, TriggerCharacterCommand } from '../typescript/src/ipcTypes'
 
 type SendCommandData<K> = {
     position: vscode.Position
@@ -10,7 +10,20 @@ type SendCommandData<K> = {
 }
 export const sendCommand = async <T, K = any>(command: TriggerCharacterCommand, sendCommandDataArg?: SendCommandData<K>): Promise<T | undefined> => {
     // plugin id disabled, languageService would not understand the special trigger character
-    if (!getExtensionSetting('enablePlugin')) return
+    if (!getExtensionSetting('enablePlugin')) {
+        console.warn('Ignoring request because plugin is disabled')
+        return
+    }
+    if (!vscode.extensions.getExtension('vscode.typescript-language-features')) {
+        const message = 'Special commands are not supported in Volar takeover mode'
+        if (passthroughExposedApiCommands.includes(command as any)) {
+            // don't spam in case of api command
+            console.error(message)
+        } else {
+            throw new Error(message)
+        }
+        return
+    }
 
     if (sendCommandDataArg?.inputOptions) {
         command = `${command}?${JSON.stringify(sendCommandDataArg.inputOptions)}` as any