fix: fix tuple signatures label display for ts 5.0

Author: zardoy

typescript/src/tupleSignature.ts

@@ -49,7 +49,11 @@ export const getTupleSignature = (node: ts.Node, typeChecker: ts.TypeChecker) =>
             if (!/^\d+$/.test(property.name)) return
             const type = typeChecker.getTypeOfSymbolAtLocation(property, targetNode!)
             let displayString = typeChecker.typeToString(type)
-            const tupleLabelDeclaration: ts.NamedTupleMember | undefined = property['target']?.['tupleLabelDeclaration']
+            const tupleLabelDeclaration: ts.NamedTupleMember | undefined =
+                property['target']?.['tupleLabelDeclaration'] ??
+                // https://github.com/microsoft/TypeScript/blob/main/src/services/symbolDisplay.ts#L648 (labelDecl)
+                // todo uncomment after ts-expose-internals update to 5.0
+                (property as any) /*import('typescript-full').TransientSymbol*/?.links?.target?.links?.tupleLabelDeclaration
             const tupleLabel = tupleLabelDeclaration?.name.text
             if (tupleLabel) {
                 displayString = `${tupleLabel}: ${displayString}`

typescript/test/completions.spec.ts

@@ -534,6 +534,17 @@ test('Additional types suggestions', () => {
     })
 })
 
+test('Tuple signature', () => {
+    const tester = fourslashLikeTester(/* ts */ `
+        const [/*1*/] = [] as [a: number]
+    `)
+    tester.completion(1, {
+        exact: {
+            names: ['a'],
+        },
+    })
+})
+
 test('Object Literal Completions', () => {
     const [_positivePositions, _negativePositions, numPositions] = fileContentsSpecialPositions(/* ts */ `
     interface Options {
@@ -684,7 +695,10 @@ test('In Keyword Completions', () => {
     const completion = pickObj(getCompletionsAtPosition(pos!, { shouldHave: true })!, 'entriesSorted', 'prevCompletionsMap')
     // this test is bad case of demonstrating how it can be used with string in union (IT SHOULDNT!)
     // but it is here to ensure this is no previous crash issue, indexes are correct when used only with objects
-    expect(completion).toMatchInlineSnapshot(`
+    expect({
+        ...completion,
+        prevCompletionsMap: Object.entries(completion.prevCompletionsMap).map(([key, v]) => [key, (v.documentationOverride as string).replaceAll('\n', '  ')]),
+    }).toMatchInlineSnapshot(`
       {
         "entriesSorted": [
           {
@@ -727,19 +741,20 @@ test('In Keyword Completions', () => {
             },
           },
         ],
-        "prevCompletionsMap": {
-          "a": {
-            "documentationOverride": "2: boolean
-
-      3: number",
-          },
-          "☆b": {
-            "documentationOverride": "2: string",
-          },
-          "☆c": {
-            "documentationOverride": "3: number",
-          },
-        },
+        "prevCompletionsMap": [
+          [
+            "a",
+            "2: boolean    3: number",
+          ],
+          [
+            "☆b",
+            "2: string",
+          ],
+          [
+            "☆c",
+            "3: number",
+          ],
+        ],
       }
     `)
 })

typescript/test/shared.ts

@@ -1,5 +1,6 @@
+/* eslint-disable import/first */
 beforeAll(() => {
-    //@ts-ignore plugin expect it to set globallly
+    //@ts-expect-error plugin expect it to set globallly
     globalThis.__WEB__ = false
 })
 
@@ -15,5 +16,6 @@ export const settingsOverride: Partial<Configuration> = {
     'arrayMethodsSnippets.enable': true,
     'codeActions.extractTypeInferName': true,
     'methodSnippets.skip': 'no-skip',
+    tupleHelpSignature: true,
 }
 export const defaultConfigFunc = await getDefaultConfigFunc(settingsOverride)

typescript/test/testing.ts

@@ -64,17 +64,16 @@ export const overrideSettings = (newOverrides: Partial<Configuration>) => {
 export const fourslashLikeTester = (contents: string, fileName = entrypoint) => {
     const [positive, _negative, numberedPositions] = fileContentsSpecialPositions(contents, fileName)
 
-    const ranges = positive.reduce(
+    const ranges = positive.reduce<number[][]>(
         (prevRanges, pos) => {
             const lastPrev = prevRanges[prevRanges.length - 1]!
             if (lastPrev.length < 2) {
                 lastPrev.push(pos)
                 return prevRanges
-            } else {
-                return [...prevRanges, [pos]]
             }
+            return [...prevRanges, [pos]]
         },
-        [[]] as number[][],
+        [[]],
     )
     return {
         completion: (marker: number | number[], matcher: CompletionMatcher, meta?) => {
@@ -127,7 +126,7 @@ export const fourslashLikeTester = (contents: string, fileName = entrypoint) =>
                     )!
                     const action = actionsGroup.actions.find(action => action.description === refactorName)!
                     const { edits } = languageService.getEditsForRefactor(fileName, {}, { pos: start, end }, actionsGroup.name, action.name, {})!
-                    const a = tsFull.textChanges.applyChanges(getCurrentFile(), edits![0]!.textChanges)
+                    const a = tsFull.textChanges.applyChanges(getCurrentFile(), edits[0]!.textChanges)
                 } else {
                     expect(appliableNames, `at marker ${mark}`).not.toContain(refactorName)
                 }
@@ -150,7 +149,7 @@ export const fileContentsSpecialPositions = (contents: string, fileName = entryp
         let mainMatch = currentMatch[1]!
         if (addOnly) mainMatch = mainMatch.slice(0, -1)
         const possiblyNum = +mainMatch
-        if (!isNaN(possiblyNum)) {
+        if (!Number.isNaN(possiblyNum)) {
             addArr[2][possiblyNum] = offset
         } else {
             addArr[mainMatch === 't' ? '0' : '1'].push(offset)