feat: Add all value to methodSnippets.skip to get the same behavior as WebStorm has out of the box

feat(based-on-feedback): Change default of `methodSnippets.skip` to `optional-and-rest` so it prefills only required params out of the box. Motivation: align default with vscode builtin behavior.
fix(method-snippets): `?` for optional arguments should be inserted only when insertMode is `always-declaration`

Author: zardoy

src/configurationType.ts

@@ -354,14 +354,16 @@ export type Configuration = {
      *
      * // only-rest
      * example({ a }, b, c)
-     * // optional-and-rest (popular)
+     * // optional-and-rest (default)
      * example({ a })
-     * // no-skip (default)
+     * // all
+     * example() // (cursor inside)
+     * // no-skip (popular)
      * example({ a }, b, c, ...d)
      * ```
-     * @default no-skip
+     * @default optional-and-rest
      */
-    'methodSnippets.skip': 'only-rest' | 'optional-and-rest' | 'no-skip'
+    'methodSnippets.skip': 'only-rest' | 'optional-and-rest' | 'all' | 'no-skip'
     /**
      * @default pick-first
      */

typescript/src/constructMethodSnippet.ts

@@ -24,7 +24,7 @@ export default (languageService: ts.LanguageService, sourceFile: ts.SourceFile,
     const { parameters } = signatures[0]!
     const printer = ts.createPrinter()
     const paramsToInsert = compact(
-        parameters.map(param => {
+        (skipMode === 'all' ? [] : parameters).map(param => {
             const valueDeclaration = param.valueDeclaration as ts.ParameterDeclaration | undefined
             const isOptional =
                 valueDeclaration && (valueDeclaration.questionToken || valueDeclaration.initializer || valueDeclaration.dotDotDotToken) ? true : false
@@ -47,7 +47,7 @@ export default (languageService: ts.LanguageService, sourceFile: ts.SourceFile,
                           !ts.isIdentifier(valueDeclaration.name) && insertMode !== 'always-declaration'
                               ? cloneBindingName(valueDeclaration.name)
                               : valueDeclaration.name,
-                          valueDeclaration.questionToken,
+                          insertMode === 'always-declaration' ? valueDeclaration.questionToken : undefined,
                           undefined,
                           insertMode === 'always-declaration' ? valueDeclaration.initializer : undefined,
                       ),

typescript/test/completions.spec.ts

@@ -156,7 +156,7 @@ describe('Method snippets', () => {
         compareMethodSnippetAgainstMarker(markers, 2, '()')
         compareMethodSnippetAgainstMarker(markers, 3, '(a)')
         compareMethodSnippetAgainstMarker(markers, 4, '($b)')
-        compareMethodSnippetAgainstMarker(markers, 5, '(a, b?, { d, e: {} }, ...c)')
+        compareMethodSnippetAgainstMarker(markers, 5, '(a, b, { d, e: {} }, ...c)')
     })
 
     test('Insert text = always-declaration', () => {
@@ -175,7 +175,7 @@ describe('Method snippets', () => {
         settingsOverride['methodSnippets.insertText'] = 'binding-name'
     })
 
-    test('methodSnippets.skip = optional-and-rest', () => {
+    test('methodSnippets.skip', () => {
         settingsOverride['methodSnippets.skip'] = 'optional-and-rest'
         const [, _, markers] = fileContentsSpecialPositions(/* ts */ `
             declare const baz: {
@@ -191,6 +191,10 @@ describe('Method snippets', () => {
 
         compareMethodSnippetAgainstMarker(markers, 1, [''])
         compareMethodSnippetAgainstMarker(markers, 2, ['a'])
+        settingsOverride['methodSnippets.skip'] = 'only-rest'
+        compareMethodSnippetAgainstMarker(markers, 1, ['a', 'b', '{ d, e: {} }'])
+        settingsOverride['methodSnippets.skip'] = 'all'
+        compareMethodSnippetAgainstMarker(markers, 2, [''])
         settingsOverride['methodSnippets.skip'] = 'no-skip'
     })
 })

typescript/test/shared.ts

@@ -14,5 +14,6 @@ export const sharedLanguageService = createLanguageService({ [entrypoint]: '' },
 export const settingsOverride: Partial<Configuration> = {
     'arrayMethodsSnippets.enable': true,
     'codeActions.extractTypeInferName': true,
+    'methodSnippets.skip': 'no-skip',
 }
 export const defaultConfigFunc = await getDefaultConfigFunc(settingsOverride)