feat: experiments.changeKindToFunction (disabled by default), change arrow functions to method kind in completions. More docs coming soon

Author: zardoy

src/configurationType.ts

@@ -443,6 +443,11 @@ export type Configuration = {
      * @default false
      */
     'experiments.excludeNonJsxCompletions': boolean
+    /**
+     * Wether to change funcntion completions to function kind
+     * @default false
+     */
+    'experiments.changeKindToFunction': boolean
     /**
      * Map *symbol - array of modules* to change sorting of imports - first available takes precedence in auto import code fixes (+ import all action)
      *

typescript/src/completions/changeKindToFunction.ts

@@ -0,0 +1,46 @@
+import { oneOf } from '@zardoy/utils'
+import { sharedCompletionContext } from './sharedContext'
+
+export default (entries: ts.CompletionEntry[]) => {
+    const { languageService } = sharedCompletionContext
+
+    const typeChecker = languageService.getProgram()!.getTypeChecker()!
+    let timeSpend = 0
+    const newEntries = entries.map(entry => {
+        const patch = (): ts.CompletionEntry | undefined => {
+            const { kind } = entry
+            if (
+                !oneOf(
+                    kind,
+                    ts.ScriptElementKind.alias,
+                    ts.ScriptElementKind.memberVariableElement,
+                    ts.ScriptElementKind.variableElement,
+                    ts.ScriptElementKind.localVariableElement,
+                    ts.ScriptElementKind.constElement,
+                    ts.ScriptElementKind.variableElement,
+                )
+            ) {
+                return
+            }
+            const symbol = entry['symbol'] as ts.Symbol | undefined
+            if (!symbol) return
+            const { valueDeclaration } = symbol
+            if (!valueDeclaration) return
+
+            const dateNow = Date.now()
+            const type = typeChecker.getTypeOfSymbolAtLocation(symbol, valueDeclaration)
+            const signatures = typeChecker.getSignaturesOfType(type, ts.SignatureKind.Call)
+            timeSpend += Date.now() - dateNow
+            if (signatures.length === 0) return
+
+            return { ...entry, kind: ts.ScriptElementKind.functionElement }
+        }
+
+        return patch() ?? entry
+    })
+
+    // remove logging once stable
+    console.log('changeKindToFunction time:', timeSpend)
+
+    return newEntries
+}

typescript/src/completionsAtPosition.ts

@@ -26,6 +26,7 @@ import escapeStringRegexp from 'escape-string-regexp'
 import addSourceDefinition from './completions/addSourceDefinition'
 import { sharedCompletionContext } from './completions/sharedContext'
 import displayImportedInfo from './completions/displayImportedInfo'
+import changeKindToFunction from './completions/changeKindToFunction'
 
 export type PrevCompletionMap = Record<
     string,
@@ -345,8 +346,15 @@ export const getCompletionsAtPosition = (
         })
     }
 
-    if (prior.isGlobalCompletion) prior.entries = markOrRemoveGlobalCompletions(prior.entries, position, languageService, c) ?? prior.entries
-    if (exactNode) prior.entries = filterJsxElements(prior.entries, exactNode, position, languageService, c) ?? prior.entries
+    if (prior.isGlobalCompletion) {
+        prior.entries = markOrRemoveGlobalCompletions(prior.entries, position, languageService, c) ?? prior.entries
+    }
+    if (exactNode) {
+        prior.entries = filterJsxElements(prior.entries, exactNode, position, languageService, c) ?? prior.entries
+    }
+    if (c('experiments.changeKindToFunction')) {
+        prior.entries = changeKindToFunction(prior.entries)
+    }
 
     if (c('correctSorting.enable')) {
         prior.entries = prior.entries.map(({ ...entry }, index) => ({