fix object literal completions to not include duplicates in unions

Author: zardoy

typescript/src/completions/objectLiteralCompletions.ts

@@ -21,11 +21,15 @@ export default (
         const objType = typeChecker.getContextualType(node)
         if (!objType) return
         const types = objType.isUnion() ? objType.types : [objType]
-        const properties = types.flatMap(type => {
-            if (isFunctionType(type, typeChecker)) return []
-            if (isObjectCompletion(type, typeChecker)) return typeChecker.getPropertiesOfType(type)
-            return []
-        })
+        const properties = types
+            .flatMap(type => {
+                if (isFunctionType(type, typeChecker)) return []
+                if (isObjectCompletion(type, typeChecker)) return typeChecker.getPropertiesOfType(type)
+                return []
+            })
+            .filter((property, i, arr) => {
+                return !arr.find(({ name }, k) => name === property.name && i !== k)
+            })
         for (const property of properties) {
             const entry = entries.find(({ name }) => name === property.name)
             if (!entry) continue

typescript/test/completions.spec.ts

@@ -314,13 +314,16 @@ test('Object Literal Completions', () => {
         usedOption,
         /*1*/
     })
+
+    const somethingWithUntions: { a: string } | { a: any[], b: string } = {/*2*/}
     `)
-    const { entriesSorted } = getCompletionsAtPosition(numPositions[1]!) ?? {}
+    const { entriesSorted: pos1 } = getCompletionsAtPosition(numPositions[1]!)!
+    const { entriesSorted: pos2 } = getCompletionsAtPosition(numPositions[2]!)!
     // todo resolve sorting problem + add tests with other keepOriginal (it was tested manually)
-    for (const entry of entriesSorted ?? []) {
+    for (const entry of [...pos1, ...pos2]) {
         entry.insertText = entry.insertText?.replaceAll('\n', '\\n')
     }
-    expect(entriesSorted).toMatchInlineSnapshot(`
+    expect(pos1).toMatchInlineSnapshot(/* json */ `
       [
         {
           "insertText": "plugins",
@@ -389,6 +392,34 @@ test('Object Literal Completions', () => {
         },
       ]
     `)
+    expect(pos2).toMatchInlineSnapshot(`
+      [
+        {
+          "insertText": "a",
+          "isSnippet": true,
+          "kind": "property",
+          "kindModifiers": "",
+          "name": "a",
+        },
+        {
+          "insertText": "b",
+          "isSnippet": true,
+          "kind": "property",
+          "kindModifiers": "",
+          "name": "b",
+        },
+        {
+          "insertText": "b: \\"$1\\",$0",
+          "isSnippet": true,
+          "kind": "property",
+          "kindModifiers": "",
+          "labelDetails": {
+            "detail": ": \\"\\",",
+          },
+          "name": "b",
+        },
+      ]
+    `)
 })
 
 // TODO move/remove this test from here