feat: Now you can exclude non-contextual signature help on manual trigger with signatureHelp.excludeBlockScope (disabled by default)

Author: zardoy

src/configurationType.ts

@@ -282,6 +282,17 @@ export type Configuration = {
      * @default true
      */
     removeDefinitionFromReferences: boolean
+    /**
+     * Make tsserver think signature help never gets triggered manually to make it not go outside of block eg:
+     * ```ts
+     * declare const a: (a) => void
+     * a(() => {/* no annoying signature help on trigger *\/ })
+     * ```
+     * But it still allow it to be displayed in return statements which is more convenient
+     * @recommended
+     * @default false
+     */
+    'signatureHelp.excludeBlockScope': boolean
     /**
      * @default true
      */

typescript/src/decorateProxy.ts

@@ -15,6 +15,7 @@ import decorateWorkspaceSymbolSearch from './workspaceSymbolSearch'
 import decorateFormatFeatures from './decorateFormatFeatures'
 import namespaceAutoImports from './namespaceAutoImports'
 import libDomPatching from './libDomPatching'
+import decorateSignatureHelp from './decorateSignatureHelp'
 
 /** @internal */
 export const thisPluginMarker = '__essentialPluginsMarker__'
@@ -88,6 +89,7 @@ export const decorateLanguageService = (
     decorateDocumentHighlights(proxy, languageService, c)
     decorateWorkspaceSymbolSearch(proxy, languageService, c, languageServiceHost)
     decorateFormatFeatures(proxy, languageService, languageServiceHost, c)
+    decorateSignatureHelp(proxy, languageService, languageServiceHost, c)
     proxy.findRenameLocations = (fileName, position, findInStrings, findInComments, providePrefixAndSuffixTextForRename) => {
         if (overrideRequestPreferences.rename) {
             try {

typescript/src/decorateSignatureHelp.ts

@@ -0,0 +1,29 @@
+import { GetConfig } from './types'
+import { findChildContainingExactPosition } from './utils'
+
+export default (proxy: ts.LanguageService, languageService: ts.LanguageService, languageServiceHost: ts.LanguageServiceHost, c: GetConfig) => {
+    proxy.getSignatureHelpItems = (fileName, position, options) => {
+        if (!c('signatureHelp.excludeBlockScope') || options?.triggerReason?.kind !== 'invoked') {
+            return languageService.getSignatureHelpItems(fileName, position, options)
+        }
+
+        const sourceFile = languageService.getProgram()!.getSourceFile(fileName)!
+        const node = findChildContainingExactPosition(sourceFile, position)
+        const returnStatement =
+            ts.findAncestor(node, node => {
+                return ts.isBlock(node) ? 'quit' : ts.isReturnStatement(node)
+            }) ?? tsFull.findPrecedingToken?.(position, sourceFile as FullSourceFile)?.kind === ts.SyntaxKind.ReturnKeyword
+
+        return languageService.getSignatureHelpItems(
+            fileName,
+            position,
+            returnStatement
+                ? options
+                : {
+                      triggerReason: {
+                          kind: 'retrigger',
+                      },
+                  },
+        )
+    }
+}