Skip to content

createI13nNode components accept unused i13n prop#565

Description

@chrissantamaria

馃憢 was poking around in this package's internals and noticed that components returned by createI13nNode seemingly accept an i13n prop in addition to i13nModel:

const I13nComponentWrapper = (props) => {
const {
// i13n props
bindClickEvent,
follow,
i13n,
i13nModel,
isLeafNode,
scanLinks,
shouldFollowLink,
children,
...restProps
} = props;

From what I can tell, this is only used to construct i13nProps which is eventually passed to CoreComponent. However, it's seemingly unused in there:

const CoreComponent = (props) => {
const {
bindClickEvent,
componentIsFunction,
children,
follow,
i13nModel,
scanLinks = {},
shouldFollowLink,
viewport,
} = props;

Out of curiosity, is this prop supported / does it functionally do anything? It's not mentioned on the docs for createI13nNode, so I assume it's leftover. If that's the case, I'm happy to take a stab at cleaning it up :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions