Skip to content

Commit 9fce067

Browse files
authored
Merge pull request #5425 from xtermjs/anthonykim1/parsingDataCharCode
Only show char codes for parsing data on trace
2 parents e9e8206 + 59241e4 commit 9fce067

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

src/common/InputHandler.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,10 @@ export class InputHandler extends Disposable implements IInputHandler {
445445

446446
// Log debug data, the log level gate is to prevent extra work in this hot path
447447
if (this._logService.logLevel <= LogLevelEnum.DEBUG) {
448-
this._logService.debug(`parsing data${typeof data === 'string' ? ` "${data}"` : ` "${Array.prototype.map.call(data, e => String.fromCharCode(e)).join('')}"`}`, typeof data === 'string'
448+
this._logService.debug(`parsing data ${typeof data === 'string' ? ` "${data}"` : ` "${Array.prototype.map.call(data, e => String.fromCharCode(e)).join('')}"`}`);
449+
}
450+
if (this._logService.logLevel === LogLevelEnum.TRACE) {
451+
this._logService.trace(`parsing data (codes)`, typeof data === 'string'
449452
? data.split('').map(e => e.charCodeAt(0))
450453
: data
451454
);
@@ -606,7 +609,7 @@ export class InputHandler extends Disposable implements IInputHandler {
606609
// since an empty cell is only set by fullwidth chars
607610
bufferRow.addCodepointToCell(this._activeBuffer.x - offset,
608611
code, chWidth);
609-
for (let delta = chWidth - oldWidth; --delta >= 0; ) {
612+
for (let delta = chWidth - oldWidth; --delta >= 0;) {
610613
bufferRow.setCellFromCodepoint(this._activeBuffer.x++, 0, 0, curAttr);
611614
}
612615
continue;
@@ -1622,7 +1625,7 @@ export class InputHandler extends Disposable implements IInputHandler {
16221625
const text = bufferRow.getString(x);
16231626
const data = new Uint32Array(text.length * length);
16241627
let idata = 0;
1625-
for (let itext = 0; itext < text.length; ) {
1628+
for (let itext = 0; itext < text.length;) {
16261629
const ch = text.codePointAt(itext) || 0;
16271630
data[idata++] = ch;
16281631
itext += ch > 0xffff ? 2 : 1;

0 commit comments

Comments
 (0)