Skip to content

Commit 32ad3a1

Browse files
committed
disable wrong webgl tests
1 parent d43b19c commit 32ad3a1

3 files changed

Lines changed: 16 additions & 7 deletions

File tree

addons/addon-webgl/test/WebglRenderer.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ test.afterAll(async () => await ctx.page.close());
2424
test.describe('WebGL Renderer Integration Tests', async () => {
2525
// HACK: webgl2 is often not supported in headless firefox on Linux
2626
// https://github.com/microsoft/playwright/issues/11566
27+
// also disable safari due to #5852
2728
if (platform() === 'linux') {
28-
test.skip(({ browserName }) => browserName === 'firefox');
29+
test.skip(({ browserName }) => browserName === 'firefox' || browserName === 'webkit');
2930
}
3031

3132
injectSharedRendererTests(ctxWrapper);

addons/addon-webgl/test/playwright.config.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ const config: PlaywrightTestConfig = {
77
{
88
name: 'Chromium',
99
use: {
10-
browserName: 'chromium'
10+
browserName: 'chromium',
11+
launchOptions: {
12+
args: ['--enable-unsafe-swiftshader']
13+
}
1114
}
1215
},
1316
{

test/playwright/SharedRendererTests.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,8 @@ export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void
169169
await pollFor(ctx.value.page, () => getCellColor(ctx.value, 8, 1), [0, 0, 0, 255]);
170170
});
171171

172-
test('background 0-15 invisible', async () => {
172+
// due to #5852
173+
test.skip('background 0-15 invisible', async () => {
173174
const theme: ITheme = {
174175
black: '#010203',
175176
red: '#040506',
@@ -335,7 +336,8 @@ export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void
335336
}
336337
});
337338

338-
test('background 16-255 invisible', async () => {
339+
// due to #5852
340+
test.skip('background 16-255 invisible', async () => {
339341
let data = '';
340342
for (let y = 0; y < 240 / 16; y++) {
341343
for (let x = 0; x < 16; x++) {
@@ -715,7 +717,8 @@ export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void
715717
}
716718
});
717719

718-
test('background true color grey invisible', async () => {
720+
// due to #5852
721+
test.skip('background true color grey invisible', async () => {
719722
let data = '';
720723
for (let y = 0; y < 16; y++) {
721724
for (let x = 0; x < 16; x++) {
@@ -872,7 +875,8 @@ export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void
872875
await pollFor(ctx.value.page, () => getCellColor(ctx.value, 8, 2), [64, 64, 64, 255]);
873876
});
874877

875-
test('should enforce half the contrast for dim cells', async () => {
878+
// due to #5852
879+
test.skip('should enforce half the contrast for dim cells', async () => {
876880
const theme: ITheme = {
877881
background: '#ffffff',
878882
black: '#2e3436',
@@ -1177,7 +1181,8 @@ export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void
11771181
await pollFor(ctx.value.page, () => getCellColor(ctx.value, 2, 3), [0, 0, 255, 255]);
11781182
await pollFor(ctx.value.page, () => getCellColor(ctx.value, 3, 3), [0, 0, 255, 255]);
11791183
});
1180-
test('#4758: multiple invisible text characters without SGR change should not be rendered', async () => {
1184+
// due to #5852
1185+
test.skip('#4758: multiple invisible text characters without SGR change should not be rendered', async () => {
11811186
// Regression test: #4758 when multiple invisible characters are used
11821187
await ctx.value.proxy.writeln(`■\x1b[8m■■`);
11831188
// Full refresh as the before result is the same as after

0 commit comments

Comments
 (0)