pkcs11_store: ignore a close without an open

wolfPKCS11 2.2.0 and earlier close a data record even when opening it
failed, and pass NULL. wolfPKCS11_Store_CloseCommit(), which
wolfPKCS11_Store_Close() calls, wrote through the handle and faulted.
It now returns 0 for NULL. unit-pkcs11_store covers both closes.

Author: LinuxJedi

src/pkcs11_store.c

@@ -807,6 +807,11 @@ int wolfPKCS11_Store_CloseCommit(void* store, int commit)
     int ret = 0;
 
     (void)commit;
+    /* Nothing was opened. wolfPKCS11 2.2.0 and earlier close a data record
+     * even when opening it failed. */
+    if (handle == NULL) {
+        return 0;
+    }
     /* Commit all pending sectors: the header sector last, so the header
      * is the atomic commit point of the window. */
     cache_flush_all();

tools/unit-tests/unit-pkcs11_store.c

@@ -364,6 +364,16 @@ START_TEST(test_close_clears_handle_state)
 }
 END_TEST
 
+START_TEST(test_close_null_store)
+{
+    /* wolfPKCS11 2.2.0 and earlier close a data record even when opening it
+     * failed, so a close without an open does nothing. */
+    wolfPKCS11_Store_Close(NULL);
+    ck_assert_int_eq(wolfPKCS11_Store_CloseCommit(NULL, 0), 0);
+    ck_assert_int_eq(wolfPKCS11_Store_CloseCommit(NULL, 1), 0);
+}
+END_TEST
+
 START_TEST(test_delete_object_ignores_metadata_prefix)
 {
     const int32_t type = DYNAMIC_TYPE_RSA;
@@ -1203,6 +1213,7 @@ Suite *wolfboot_suite(void)
     tcase_add_test(tcase_store_and_load_objs, test_store_and_load_objs);
     tcase_add_test(tcase_cross_sector_write, test_cross_sector_write_preserves_length);
     tcase_add_test(tcase_close, test_close_clears_handle_state);
+    tcase_add_test(tcase_close, test_close_null_store);
     tcase_add_test(tcase_delete_object, test_delete_object_ignores_metadata_prefix);
     tcase_add_test(tcase_delete_corrupted, test_delete_object_corrupted_pos_no_oob);
     tcase_add_test(tcase_delete_corrupted,