Skip to content
This repository was archived by the owner on Jan 31, 2022. It is now read-only.
This repository was archived by the owner on Jan 31, 2022. It is now read-only.

Possible conflicts between class names #8

Description

@stof

you are adding use statements, but without checking if they could conflict with other classes in the same namespace (possible only if the user try to typehint a class ...\Base* as all om classes start with this prefix though) or with other use statement (more likely).

I see 2 possible ways to fix it:

  • don't generate a use statement, using the FQCN in the method signature => no conflict ever, but ugly generated code
  • alias the use statement to ensure the uniqueness => conflict possible if the logic choosing the alias is bad, ugliness possible depending of the generated alias

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions