Adding input checking

Author: martinthomson

nodejs/ece.js

@@ -265,6 +265,9 @@ function encryptRecord(key, counter, buffer, pad, padSize) {
  * crypto.createDiffieHellman()).
  */
 function encrypt(buffer, params) {
+  if (!Buffer.isBuffer(buffer)) {
+    throw new Error('buffer argument must be a Buffer');
+  }
   var key = deriveKeyAndNonce(params, MODE_ENCRYPT);
   var rs = determineRecordSize(params);
   var start = 0;

nodejs/test.js

@@ -32,6 +32,15 @@ function logbuf(msg, buf) {
   }
 }
 
+function validate() {
+  ['hello', null, 1, NaN, [], {}].forEach(function(v) {
+    try {
+      encrypt('hello', {});
+      throw new Error('should insist on a buffer');
+    } catch (e) {}
+  });
+}
+
 function encryptDecrypt(length, encryptParams, decryptParams) {
   decryptParams = decryptParams || encryptParams;
   logbuf('Salt', encryptParams.salt);
@@ -155,6 +164,7 @@ function useDH() {
   encryptDecrypt(length.readUInt16BE(2), encryptParams, decryptParams);
 }
 
+validate();
 var i;
 for (i = 0; i < count; ++i) {
   [ useExplicitKey,