Commit 9eaeeb9
authored
fix: resolve
## Summary
- Add `shell: bash` to the "Set binding version" and "Verify version replacement" steps in the release workflow, fixing PowerShell quoting issues that caused `replace-file-content` to silently fail on Windows runners
- Add a verification step after version replacement to catch silent failures early
- Enable the `replace-file-content` snap test on win32 (remove `ignoredPlatforms`)
## Root Cause
The `build-rust` job in `release.yml` runs on `windows-latest` without specifying a shell, so GitHub Actions defaults to PowerShell. PowerShell mangles embedded double quotes in single-quoted arguments like `'version = "0.0.0"'`, causing the search string to never match. The replacement silently fails, and the binary compiles with `version = "0.0.0"` still in `Cargo.toml`.
Verified by temporarily disabling the fix and confirming the CI fails with `version = "0.0.0"` still present.
## Test plan
- [x] CI passes with `shell: bash` on the version replacement steps
- [x] Verified root cause by disabling the fix and confirming CI failure
🤖 Generated with [Claude Code](https://claude.com/claude-code)vp --version showing v0.0.0 on Windows (#767)1 parent 77322a0 commit 9eaeeb9
2 files changed
Lines changed: 17 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| 77 | + | |
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
80 | 97 | | |
81 | 98 | | |
82 | 99 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
| |||
0 commit comments