chore: fix more lint errors. (#580)

Somehow #579 was merged by Graphite without passing CI. The fixes are in this PR.

Author: cpojer

packages/cli/build.ts

@@ -111,7 +111,7 @@ async function buildNapiBinding() {
 }
 
 async function buildCli() {
-  const tsconfig = readJsonConfigFile(join(projectDir, 'tsconfig.json'), sys.readFile);
+  const tsconfig = readJsonConfigFile(join(projectDir, 'tsconfig.json'), sys.readFile.bind(sys));
 
   const { options: initialOptions } = parseJsonSourceFileConfigFileContent(
     tsconfig,
@@ -544,7 +544,7 @@ async function createConditionalShim(
         importResult.default = `./dist/test/${shimBaseName}.js`;
       }
 
-      (result as Record<string, unknown>).import = importResult;
+      result.import = importResult;
     }
   }
 
@@ -555,7 +555,7 @@ async function createConditionalShim(
     if (typeof requireValue === 'string') {
       const cjsPath = join(shimDir, `${baseFileName}.cjs`);
       await writeFile(cjsPath, `module.exports = require('${testImportSpecifier}');\n`);
-      (result as Record<string, unknown>).require = `./dist/test/${shimBaseName}.cjs`;
+      result.require = `./dist/test/${shimBaseName}.cjs`;
     } else if (typeof requireValue === 'object' && requireValue !== null) {
       const requireResult: Record<string, string> = {};
 
@@ -575,7 +575,7 @@ async function createConditionalShim(
         requireResult.default = `./dist/test/${shimBaseName}.cjs`;
       }
 
-      (result as Record<string, unknown>).require = requireResult;
+      result.require = requireResult;
     }
   }
 

packages/cli/src/pack-bin.ts

@@ -121,4 +121,5 @@ export async function runCLI(): Promise<void> {
 if (module.enableCompileCache) {
   module.enableCompileCache();
 }
-runCLI();
+
+await runCLI();

packages/core/build-support/find-create-require.ts

@@ -164,7 +164,7 @@ function findCreateRequireInStaticImports(
       if (!node.init || node.init.type !== 'CallExpression') {
         return;
       }
-      const call = node.init as CallExpression;
+      const call = node.init;
       if (call.callee.type === 'Identifier' && call.callee.name === createRequireLocalName) {
         if (node.id.type === 'Identifier') {
           requireVarName = node.id.name;
@@ -207,7 +207,7 @@ function isGetBuiltinModuleCall(expr: Expression): boolean {
   if (expr.type !== 'CallExpression') {
     return false;
   }
-  const call = expr as CallExpression;
+  const call = expr;
 
   // Check callee is a member expression with property `getBuiltinModule`
   if (call.callee.type !== 'MemberExpression' || call.callee.computed) {
@@ -251,7 +251,7 @@ function findCreateRequireInGlobalModule(
         return;
       }
 
-      const call = node.init as CallExpression;
+      const call = node.init;
 
       // Check if callee is a MemberExpression with property `createRequire`
       if (call.callee.type !== 'MemberExpression' || call.callee.computed) {

packages/global/src/create/bin.ts

@@ -438,7 +438,7 @@ Use \`vp create --list\` to list all available templates, or run \`vp create --h
     rewriteMonorepo(workspaceInfo);
     await runViteInstall(fullPath, options.interactive);
     prompts.outro(`✔ Created ${accent(projectDir)}!`);
-    log(`${styleText('bold', 'Next steps:')}`);
+    log(styleText('bold', 'Next steps:'));
     log(`  ${accent(`cd ${projectDir}`)}`);
     log(`  ${accent(`vp dev ${InitialMonorepoAppDir}`)}`);
     return;
@@ -562,7 +562,7 @@ Use \`vp create --list\` to list all available templates, or run \`vp create --h
 }
 
 function showNextSteps(projectDir: string, isMonorepo: boolean) {
-  log(`${styleText('bold', 'Next steps:')}`);
+  log(styleText('bold', 'Next steps:'));
   if (isMonorepo) {
     log(`  ${accent(`vp dev ${projectDir}`)}`);
   } else {

packages/global/src/index.ts

@@ -11,12 +11,12 @@ if (args[0] === 'help' && args[1]) {
 const command = args[0];
 
 if (command === 'create') {
-  import('./create/bin.js');
+  await import('./create/bin.js');
 } else if (command === 'migrate') {
-  import('./migration/bin.js');
+  await import('./migration/bin.js');
 } else if (command === '--version' || command === '-V') {
-  import('./version.js');
+  await import('./version.js');
 } else {
   // Delegate all other commands to local CLI
-  import('./local/bin.js');
+  await import('./local/bin.js');
 }

packages/global/src/local/bin.ts

@@ -74,5 +74,4 @@ if (!localCliMetadata) {
   prompts.outro(`Using local Vite+ CLI`);
 }
 
-// delegate to local CLI
-import(pathToFileURL(join(localCliMetadata.path, 'dist', 'bin.js')).href);
+await import(pathToFileURL(join(localCliMetadata.path, 'dist', 'bin.js')).href);

packages/global/src/migration/bin.ts

@@ -80,7 +80,7 @@ function parseArgs() {
   const nonInteractive = parsed['non-interactive'] ?? parsed.nonInteractive;
   const interactive = nonInteractive ? false : parsed.interactive;
 
-  let projectPath = parsed._[0] as string;
+  let projectPath = parsed._[0];
   if (projectPath) {
     projectPath = path.resolve(process.cwd(), projectPath);
   } else {

packages/global/src/utils/terminal.ts

@@ -63,19 +63,18 @@ function gradient(count: number, startRgb: RGB, endRgb: RGB) {
 }
 
 function colorize(text: string, colors: Array<RGB>) {
-  const chars = [...text];
-  if (chars.length === 0) {
+  if (text.length === 0) {
     return '';
   }
 
-  const denom = Math.max(chars.length - 1, 1);
+  const denom = Math.max(text.length - 1, 1);
   const maxIdx = colors.length - 1;
 
   let out = '';
-  for (let i = 0; i < chars.length; i++) {
+  for (let i = 0; i < text.length; i++) {
     const idx = Math.round((i / denom) * maxIdx);
     const [r, g, b] = colors[idx];
-    out += fgRgb(r, g, b) + chars[i];
+    out += fgRgb(r, g, b) + text[i];
   }
   return out + RESET;
 }
@@ -213,10 +212,7 @@ export async function getVitePlusHeader() {
     return `VITE+ - ${textA}${textB}`;
   }
 
-  return `${styleText(
-    'bold',
-    `VITE+ - ${textA}${colorize(textB, await getGradientColors(textB))}`,
-  )}`;
+  return styleText('bold', `VITE+ - ${textA}${colorize(textB, await getGradientColors(textB))}`);
 }
 
 export function log(message: string) {

packages/global/src/utils/yaml.ts

@@ -1,13 +1,13 @@
 import fs from 'node:fs';
 
-import { type Document, type ParsedNode, parseDocument, parse as parseYaml, Scalar } from 'yaml';
+import { type Document, parseDocument, parse as parseYaml, Scalar } from 'yaml';
 
 export function readYamlFile<T = Record<string, unknown>>(file: string): T {
   const content = fs.readFileSync(file, 'utf-8');
   return parseYaml(content) as T;
 }
 
-export type YamlDocument = Document.Parsed<ParsedNode, true>;
+export type YamlDocument = Document.Parsed;
 
 export function editYamlFile(file: string, callback: (doc: YamlDocument) => void) {
   const content = fs.readFileSync(file, 'utf-8');

packages/global/src/version.ts

@@ -180,4 +180,4 @@ export async function printVersion(cwd: string) {
   }
 }
 
-printVersion(process.cwd());
+await printVersion(process.cwd());