fix(pack): replace "tsdown" with "vp pack" in error messages (#642)

Add brandTsdown() build-time patching to replace upstream "tsdown"
branding in the bundled error message when no input files are found.

Follows the same post-build branding pattern as brandVitest().

Author: fengmk2

packages/cli/snap-tests/command-pack-no-input/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "command-pack-no-input",
+  "version": "1.0.0",
+  "type": "module"
+}

packages/cli/snap-tests/command-pack-no-input/snap.txt

@@ -0,0 +1,4 @@
+[1]> vp pack # should not mention tsdown in error
+
+ ERROR  Error: undefined No input files, try "vp pack <your-file>" or create src/index.ts
+

packages/cli/snap-tests/command-pack-no-input/steps.json

@@ -0,0 +1,7 @@
+{
+  "ignoredPlatforms": ["win32"],
+  "env": {
+    "VITE_DISABLE_AUTO_INSTALL": "1"
+  },
+  "commands": ["vp pack # should not mention tsdown in error"]
+}

packages/core/build.ts

@@ -49,6 +49,7 @@ await bundleRolldownPluginutils();
 await bundleRolldown();
 await buildVite();
 await bundleTsdown();
+await brandTsdown();
 await bundleVitepress();
 await mergePackageJson();
 await syncLicenseFromRoot();
@@ -350,6 +351,33 @@ async function bundleTsdown() {
   });
 }
 
+async function brandTsdown() {
+  const tsdownDistDir = join(projectDir, 'dist/tsdown');
+  const buildFiles = await glob(toPosixPath(join(tsdownDistDir, 'build-*.js')), { absolute: true });
+  if (buildFiles.length === 0) {
+    throw new Error('brandTsdown: no build chunk found in dist/tsdown/');
+  }
+
+  const search = '"tsdown <your-file>"';
+  const replacement = '"vp pack <your-file>"';
+  let patched = false;
+
+  for (const buildFile of buildFiles) {
+    let content = await readFile(buildFile, 'utf-8');
+    if (!content.includes(search)) {
+      continue;
+    }
+    content = content.replace(search, replacement);
+    await writeFile(buildFile, content, 'utf-8');
+    console.log(`Branded tsdown → vp pack in ${buildFile}`);
+    patched = true;
+  }
+
+  if (!patched) {
+    throw new Error(`brandTsdown: pattern ${search} not found in any build chunk`);
+  }
+}
+
 // Actually do nothing now, we will polish it in the future when `vitepress` is ready
 async function bundleVitepress() {
   const vitepressSourceDir = resolve(projectDir, 'node_modules/vitepress');

packages/tools/src/utils.ts

@@ -132,6 +132,8 @@ export function replaceUnstableOutput(output: string, cwd?: string) {
       // [PLUGIN_TIMINGS] Warning: Your build spent significant time in plugins. Here is a breakdown:
       //   - externalize-deps (74%)
       .replaceAll(/\[PLUGIN_TIMINGS\] Warning:.*?\n(?:\s+-\s+.+?\n)*/g, '')
+      // remove JS stack traces (lines starting with "    at ")
+      .replaceAll(/\n\s+at .+/g, '')
   );
 }
 

rfcs/cli-output-polish.md

@@ -325,6 +325,18 @@ These are straightforward string replacements in the source, verified by snap te
 
 For oxlint and oxfmt, pre-spawn banners or build-time patching can follow the same pattern once their source/dist is bundled.
 
+### Phase 3.5: Rebrand tsdown Output
+
+tsdown is bundled via `@voidzero-dev/vite-plus-core`. Its build script (`packages/core/build.ts`) bundles tsdown's dist files via rolldown.
+
+#### 3.5.1 Approach: Build-time patching of bundled build chunk
+
+After `bundleTsdown()` rebuilds tsdown, a `brandTsdown()` step patches the build chunk (`dist/tsdown/build-*.js`) with string replacements:
+
+1. `"tsdown <your-file>"` → `"vp pack <your-file>"` — error message when no input files found
+
+Internal identifiers are left unchanged: debug namespaces (`tsdown:*`), plugin names (`tsdown:external`), config prefix (`tsdown.config`), temp dirs (`tsdown-pack-`).
+
 ### Phase 4: JS-Side Output Consistency
 
 The JS code in `packages/cli/src/utils/terminal.ts` already has `accent()`, `headline()`, `muted()`, `success()`, `error()` functions. Extend it with prefix functions matching the Rust convention:
@@ -435,6 +447,12 @@ These are internal identifiers, API references, or project name references:
 8. Migrate `vite_install/src/commands/*.rs` Warning/Note messages
 9. Update snap tests
 
+### Phase 2.5: tsdown Branding
+
+1. Add `brandTsdown()` in `packages/core/build.ts` after `bundleTsdown()`
+2. Patch `dist/tsdown/build-*.js` with string replacement: `"tsdown <your-file>"` → `"vp pack <your-file>"`
+3. Update snap tests
+
 ### Phase 3: Sub-tool Banners
 
 1. Add `print_banner()` for vitest, oxlint, oxfmt in `packages/cli/binding/src/cli.rs`
@@ -459,6 +477,7 @@ Many existing snap tests will need updates due to prefix and branding changes:
 - `snap-tests/command-dev-*/snap.txt` — vite banner change
 - `snap-tests/command-build-*/snap.txt` — build banner change
 - All `Warning:`/`Note:` snap outputs across global snap tests
+- `snap-tests/command-pack-no-input/snap.txt` — tsdown error message branding
 
 **Process:** Run `pnpm -F vite-plus snap-test` after each phase, review `git diff` on `snap.txt` files, and verify the new formatting matches expectations.