Skip to content

Commit 2ce7af3

Browse files
Giorno-Giovanaa.zavernyaevfengmk2
authored
fix: upgrade reqwest from 0.12 to 0.13 and rename the rustls-tls feature to rustls (#1068)
closes #1014 Motivation vp install fails on macOS with a TLS error when trying to download the Node.js runtime from nodejs.org: error: Failed to download Node.js runtime: Failed to download from https://nodejs.org/dist/v22.18.0/SHASUMS256.txt: error sending request for url The root cause is how reqwest 0.12 handles TLS certificate verification on non-Windows platforms. With the rustls-tls feature, it uses webpki-roots — a hardcoded bundle of Mozilla root certificates compiled into the binary. If the server's certificate chain involves a CA not present in that bundle (or the bundle is outdated), TLS verification fails, even though the system's certificate store (macOS Keychain) trusts the certificate. reqwest 0.13 replaces the rustls-tls feature with rustls, which uses rustls-platform-verifier instead of webpki-roots. This verifier delegates certificate validation to the OS-native certificate store (Security.framework on macOS, SChannel on Windows), matching the behavior of curl and other system tools. --------- Co-authored-by: a.zavernyaev <a.zavernyaev@tbank.ru> Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
1 parent 0e3c352 commit 2ce7af3

File tree

11 files changed

+183
-106
lines changed

11 files changed

+183
-106
lines changed

.github/workflows/test-standalone-install.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ jobs:
228228
-e VITE_PLUS_VERSION=alpha \
229229
-e CI=true \
230230
alpine:3.21 sh -c "
231-
# libstdc++ is needed by unofficial-builds Node.js musl binary
231+
# libstdc++: required by unofficial-builds Node.js musl binary
232232
apk add --no-cache bash curl ca-certificates libstdc++
233233
cat /workspace/packages/cli/install.sh | bash
234234
export PATH=\"\$HOME/.vite-plus/bin:\$PATH\"

0 commit comments

Comments
 (0)