From 9f732bfde5cfe039c14ea59dc1d0dc7fd9646da9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ng=C3=B4=20Quang=20H=C3=B2a?= Date: Tue, 26 May 2026 15:27:03 +0700 Subject: [PATCH] fix(models): register Gemma-4-31B-it in the Model enum + MODEL_CONFIG MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #1 added `gemma4: 'Gemma-4-31B-it'` to DB_MODEL_TO_DISPLAY in constants/, but missed the parallel registration in the app's own Model enum + MODEL_CONFIG (data-mappings.ts). Result: MODEL_OPTIONS doesn't include Gemma-4-31B-it, so: GlobalFilterContext.availableModels = MODEL_OPTIONS.filter(... matches availability ...) // → [] because gemma4 isn't in MODEL_OPTIONS to begin with The PR #4 fallback effect saw `availableModels.length === 0` and bailed out, leaving the user stuck on the hardcoded DeepSeek_R1 default which has no data → "No data for DeepSeek-R1-0528" empty state on /evaluation. Add Gemma_4_31B to the enum + MODEL_CONFIG so the model surfaces in the dropdown and the fallback effect can land on it. Co-Authored-By: Claude Opus 4.7 (1M context) --- packages/app/src/lib/data-mappings.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/app/src/lib/data-mappings.ts b/packages/app/src/lib/data-mappings.ts index 6a5439256..905a4e026 100644 --- a/packages/app/src/lib/data-mappings.ts +++ b/packages/app/src/lib/data-mappings.ts @@ -8,6 +8,7 @@ export enum Model { MiniMax_M2_5 = 'MiniMax-M2.5', GLM_5 = 'GLM-5', DeepSeek_V4_Pro = 'DeepSeek-V4-Pro', + Gemma_4_31B = 'Gemma-4-31B-it', } export type CategoryTag = 'default' | 'experimental' | 'deprecated' | 'hidden'; @@ -71,6 +72,7 @@ const MODEL_CONFIG: Record = { [Model.GptOss]: { label: 'gpt-oss 120B', prefix: 'gptoss', category: 'default' }, [Model.Llama3_3_70B]: { label: 'Llama 3.3 70B Instruct', prefix: '70b', category: 'deprecated' }, [Model.Llama3_1_70B]: { label: 'Llama 3.1 70B Instruct', prefix: '', category: 'hidden' }, + [Model.Gemma_4_31B]: { label: 'Gemma-4 31B', prefix: 'gemma4', category: 'default' }, }; function modelsByCategory(cat: CategoryTag): ReadonlySet {