Skip to content

Commit dfeca3e

Browse files
committed
refactor(stovepipe): omit queue enablement migrations
1 parent 14dc717 commit dfeca3e

4 files changed

Lines changed: 0 additions & 30 deletions

File tree

‎stovepipe/extension/storage/mysql/migrations/BUILD.bazel‎

Lines changed: 0 additions & 4 deletions
This file was deleted.

‎stovepipe/extension/storage/mysql/migrations/queue_enablement.sql‎

Lines changed: 0 additions & 7 deletions
This file was deleted.

‎test/integration/stovepipe/extension/storage/mysql/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ go_test(
99
],
1010
data = [
1111
"docker-compose.yml",
12-
"//stovepipe/extension/storage/mysql/migrations:queue_enablement.sql",
1312
"//stovepipe/extension/storage/mysql/schema",
1413
],
1514
tags = [

‎test/integration/stovepipe/extension/storage/mysql/storage_test.go‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ package mysql
1717
import (
1818
"context"
1919
"database/sql"
20-
"os"
2120
"testing"
2221

2322
_ "github.com/go-sql-driver/mysql"
@@ -55,23 +54,6 @@ func TestMySQLStorage(t *testing.T) {
5554
require.NoError(t, err, "failed to create storage")
5655
factory := mysqlFactory{backend: backend}
5756

58-
t.Run("QueueEnablementMigration", func(t *testing.T) {
59-
resetStorage(t, db)
60-
_, err := db.ExecContext(ctx, "ALTER TABLE queue DROP COLUMN enablement, DROP COLUMN enablement_version, DROP COLUMN effective_from_commit_uri, DROP COLUMN enablement_changed_at_ms")
61-
require.NoError(t, err)
62-
_, err = db.ExecContext(ctx, "INSERT INTO queue (name, last_green_uri, in_flight_count, latest_request_id, version) VALUES ('existing/main', 'green', 2, '9', 12)")
63-
require.NoError(t, err)
64-
migration, err := os.ReadFile(testutil.Runfile("stovepipe/extension/storage/mysql/migrations/queue_enablement.sql"))
65-
require.NoError(t, err)
66-
_, err = db.ExecContext(ctx, string(migration))
67-
require.NoError(t, err)
68-
bound, err := backend.For("existing/main")
69-
require.NoError(t, err)
70-
queue, err := bound.GetQueueStore().Get(ctx, "existing/main")
71-
require.NoError(t, err)
72-
require.Equal(t, entity.Queue{Name: "existing/main", LastGreenURI: "green", InFlightCount: 2, LatestRequestID: "9", Version: 12}, queue)
73-
})
74-
7557
t.Run("QueueSummaryStores", func(t *testing.T) {
7658
resetStorage(t, db)
7759
testQueueSummaryStores(t, ctx, backend)

0 commit comments

Comments
 (0)