|
| 1 | +// Copyright (c) 2026 Uber Technologies, Inc. |
| 2 | +// |
| 3 | +// Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | +// you may not use this file except in compliance with the License. |
| 5 | +// You may obtain a copy of the License at |
| 6 | +// |
| 7 | +// http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | +// |
| 9 | +// Unless required by applicable law or agreed to in writing, software |
| 10 | +// distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | +// See the License for the specific language governing permissions and |
| 13 | +// limitations under the License. |
| 14 | + |
| 15 | +package controller |
| 16 | + |
| 17 | +import ( |
| 18 | + "context" |
| 19 | + "fmt" |
| 20 | + "testing" |
| 21 | + |
| 22 | + "github.com/stretchr/testify/assert" |
| 23 | + "github.com/stretchr/testify/require" |
| 24 | + "github.com/uber/submitqueue/platform/errs" |
| 25 | + "github.com/uber/submitqueue/submitqueue/entity" |
| 26 | + basestorage "github.com/uber/submitqueue/submitqueue/extension/storage" |
| 27 | + "go.uber.org/mock/gomock" |
| 28 | +) |
| 29 | + |
| 30 | +func TestList_ConsistencyErrors(t *testing.T) { |
| 31 | + receipt := entity.RequestReceipt{Queue: "q", RequestID: "1", ReceivedAtMs: 100} |
| 32 | + summary := entity.RequestSummary{Queue: "q", RequestID: "1", ReceivedAtMs: 100, Status: entity.RequestStatusAccepted} |
| 33 | + tests := []struct { |
| 34 | + name string |
| 35 | + changeReceipt func(*entity.RequestReceipt) |
| 36 | + changeSummary func(*entity.RequestSummary) |
| 37 | + readErr error |
| 38 | + }{ |
| 39 | + {name: "receipt from another queue", changeReceipt: func(r *entity.RequestReceipt) { r.Queue = "other" }}, |
| 40 | + {name: "receipt has no request ID", changeReceipt: func(r *entity.RequestReceipt) { r.RequestID = "" }}, |
| 41 | + {name: "receipt has no time", changeReceipt: func(r *entity.RequestReceipt) { r.ReceivedAtMs = 0 }}, |
| 42 | + {name: "receipt has negative time", changeReceipt: func(r *entity.RequestReceipt) { r.ReceivedAtMs = -1 }}, |
| 43 | + {name: "missing summary", readErr: fmt.Errorf("get summary: %w", basestorage.ErrNotFound)}, |
| 44 | + {name: "summary from another queue", changeSummary: func(s *entity.RequestSummary) { s.Queue = "other" }}, |
| 45 | + {name: "summary for another request", changeSummary: func(s *entity.RequestSummary) { s.RequestID = "2" }}, |
| 46 | + {name: "summary has another receipt time", changeSummary: func(s *entity.RequestSummary) { s.ReceivedAtMs = 101 }}, |
| 47 | + {name: "hidden accepting summary", changeSummary: func(s *entity.RequestSummary) { s.Status = entity.RequestStatusAccepting }}, |
| 48 | + } |
| 49 | + for _, tt := range tests { |
| 50 | + t.Run(tt.name, func(t *testing.T) { |
| 51 | + f := newListTestFixture(t) |
| 52 | + badReceipt, badSummary := receipt, summary |
| 53 | + if tt.changeReceipt != nil { |
| 54 | + tt.changeReceipt(&badReceipt) |
| 55 | + } else { |
| 56 | + if tt.changeSummary != nil { |
| 57 | + tt.changeSummary(&badSummary) |
| 58 | + } |
| 59 | + f.summaries.EXPECT().Get(gomock.Any(), "1").Return(badSummary, tt.readErr) |
| 60 | + } |
| 61 | + f.queueConfigs.EXPECT().Get(gomock.Any(), "q").Return(entity.QueueConfig{}, nil) |
| 62 | + f.receipts.EXPECT().List(gomock.Any(), gomock.Any()).Return([]entity.RequestReceipt{badReceipt}, nil) |
| 63 | + |
| 64 | + result, err := f.controller.List(context.Background(), entity.ListRequest{Queue: "q", ReceivedAtOrAfterMs: 1, ReceivedBeforeMs: 200}) |
| 65 | + |
| 66 | + require.Error(t, err) |
| 67 | + assert.True(t, IsInternalConsistency(err)) |
| 68 | + assert.False(t, errs.IsUserError(err)) |
| 69 | + assert.Equal(t, entity.ListResult{}, result) |
| 70 | + }) |
| 71 | + } |
| 72 | +} |
| 73 | + |
| 74 | +func TestList_DoesNotReturnPartialPage(t *testing.T) { |
| 75 | + f := newListTestFixture(t) |
| 76 | + f.queueConfigs.EXPECT().Get(gomock.Any(), "q").Return(entity.QueueConfig{}, nil) |
| 77 | + f.receipts.EXPECT().List(gomock.Any(), gomock.Any()).Return([]entity.RequestReceipt{ |
| 78 | + {Queue: "q", RequestID: "2", ReceivedAtMs: 100}, |
| 79 | + {Queue: "q", RequestID: "1", ReceivedAtMs: 90}, |
| 80 | + }, nil) |
| 81 | + f.summaries.EXPECT().Get(gomock.Any(), "2").Return(entity.RequestSummary{ |
| 82 | + Queue: "q", RequestID: "2", ReceivedAtMs: 100, Status: entity.RequestStatusAccepted, |
| 83 | + }, nil) |
| 84 | + f.summaries.EXPECT().Get(gomock.Any(), "1").Return(entity.RequestSummary{}, basestorage.ErrNotFound) |
| 85 | + |
| 86 | + result, err := f.controller.List(context.Background(), entity.ListRequest{Queue: "q", ReceivedAtOrAfterMs: 1, ReceivedBeforeMs: 200}) |
| 87 | + |
| 88 | + assert.True(t, IsInternalConsistency(err)) |
| 89 | + assert.Equal(t, entity.ListResult{}, result) |
| 90 | +} |
0 commit comments