|
| 1 | +// Copyright (c) 2026 Uber Technologies, Inc. |
| 2 | +// |
| 3 | +// Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | +// you may not use this file except in compliance with the License. |
| 5 | +// You may obtain a copy of the License at |
| 6 | +// |
| 7 | +// http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | +// |
| 9 | +// Unless required by applicable law or agreed to in writing, software |
| 10 | +// distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | +// See the License for the specific language governing permissions and |
| 13 | +// limitations under the License. |
| 14 | + |
| 15 | +package mysql |
| 16 | + |
| 17 | +import ( |
| 18 | + "context" |
| 19 | + "database/sql" |
| 20 | + "errors" |
| 21 | + "fmt" |
| 22 | + |
| 23 | + "github.com/uber-go/tally" |
| 24 | + "github.com/uber/submitqueue/platform/metrics" |
| 25 | + "github.com/uber/submitqueue/stovepipe/entity" |
| 26 | + "github.com/uber/submitqueue/stovepipe/extension/storage" |
| 27 | +) |
| 28 | + |
| 29 | +type openBuildIssueStore struct { |
| 30 | + db *sql.DB |
| 31 | + scope tally.Scope |
| 32 | + queue string |
| 33 | +} |
| 34 | + |
| 35 | +// NewOpenBuildIssueStore binds currently open issues to queue over the shared database. |
| 36 | +func NewOpenBuildIssueStore(db *sql.DB, scope tally.Scope, queue string) storage.OpenBuildIssueStore { |
| 37 | + return &openBuildIssueStore{db: db, scope: scope, queue: queue} |
| 38 | +} |
| 39 | + |
| 40 | +func (s *openBuildIssueStore) Create(ctx context.Context, issue entity.OpenBuildIssue) (retErr error) { |
| 41 | + op := metrics.Begin(s.scope, "create", metrics.StorageLatencyBuckets) |
| 42 | + defer func() { op.Complete(retErr) }() |
| 43 | + |
| 44 | + if err := s.validateIssue(issue, true); err != nil { |
| 45 | + return err |
| 46 | + } |
| 47 | + if issue.Version <= 0 { |
| 48 | + return fmt.Errorf("open build issue version must be positive") |
| 49 | + } |
| 50 | + |
| 51 | + _, err := s.db.ExecContext(ctx, |
| 52 | + `INSERT INTO open_build_issue (queue, task_id, unit_id, first_observed_build_id, last_observed_build_id, version) |
| 53 | + VALUES (?, ?, ?, ?, ?, ?)`, |
| 54 | + s.queue, issue.TaskID, issue.UnitID, issue.FirstObservedBuildID, issue.LastObservedBuildID, issue.Version) |
| 55 | + if err != nil { |
| 56 | + if isDuplicateEntry(err) { |
| 57 | + return fmt.Errorf("open build issue task=%q unit=%q: %w", issue.TaskID, issue.UnitID, storage.ErrAlreadyExists) |
| 58 | + } |
| 59 | + |
| 60 | + return fmt.Errorf("failed to create open build issue: %w", err) |
| 61 | + } |
| 62 | + |
| 63 | + return nil |
| 64 | +} |
| 65 | + |
| 66 | +func (s *openBuildIssueStore) Get(ctx context.Context, taskID, unitID string) (ret entity.OpenBuildIssue, retErr error) { |
| 67 | + op := metrics.Begin(s.scope, "get", metrics.StorageLatencyBuckets) |
| 68 | + defer func() { op.Complete(retErr) }() |
| 69 | + |
| 70 | + if err := validateBuildIssueKey(s.queue, "", taskID, unitID); err != nil { |
| 71 | + return entity.OpenBuildIssue{}, err |
| 72 | + } |
| 73 | + |
| 74 | + var issue entity.OpenBuildIssue |
| 75 | + err := s.db.QueryRowContext(ctx, |
| 76 | + `SELECT task_id, unit_id, first_observed_build_id, last_observed_build_id, version |
| 77 | + FROM open_build_issue WHERE queue = ? AND task_id = ? AND unit_id = ?`, |
| 78 | + s.queue, taskID, unitID, |
| 79 | + ).Scan(&issue.TaskID, &issue.UnitID, &issue.FirstObservedBuildID, &issue.LastObservedBuildID, &issue.Version) |
| 80 | + if errors.Is(err, sql.ErrNoRows) { |
| 81 | + return entity.OpenBuildIssue{}, storage.WrapNotFound(err) |
| 82 | + } |
| 83 | + if err != nil { |
| 84 | + return entity.OpenBuildIssue{}, fmt.Errorf("failed to get open build issue: %w", err) |
| 85 | + } |
| 86 | + |
| 87 | + return issue, nil |
| 88 | +} |
| 89 | + |
| 90 | +func (s *openBuildIssueStore) Update(ctx context.Context, issue entity.OpenBuildIssue, oldVersion, newVersion int32) (retErr error) { |
| 91 | + op := metrics.Begin(s.scope, "update", metrics.StorageLatencyBuckets) |
| 92 | + defer func() { op.Complete(retErr) }() |
| 93 | + |
| 94 | + if err := s.validateIssue(issue, true); err != nil { |
| 95 | + return err |
| 96 | + } |
| 97 | + if oldVersion <= 0 || newVersion <= 0 { |
| 98 | + return fmt.Errorf("open build issue versions must be positive") |
| 99 | + } |
| 100 | + |
| 101 | + result, err := s.db.ExecContext(ctx, |
| 102 | + `UPDATE open_build_issue SET last_observed_build_id = ?, version = ? |
| 103 | + WHERE queue = ? AND task_id = ? AND unit_id = ? AND first_observed_build_id = ? AND version = ?`, |
| 104 | + issue.LastObservedBuildID, newVersion, s.queue, issue.TaskID, issue.UnitID, issue.FirstObservedBuildID, oldVersion) |
| 105 | + if err != nil { |
| 106 | + return fmt.Errorf("failed to update open build issue: %w", err) |
| 107 | + } |
| 108 | + |
| 109 | + return checkOpenBuildIssueMutation(result) |
| 110 | +} |
| 111 | + |
| 112 | +func (s *openBuildIssueStore) Delete(ctx context.Context, issue entity.OpenBuildIssue, oldVersion int32) (retErr error) { |
| 113 | + op := metrics.Begin(s.scope, "delete", metrics.StorageLatencyBuckets) |
| 114 | + defer func() { op.Complete(retErr) }() |
| 115 | + |
| 116 | + if err := s.validateIssue(issue, false); err != nil { |
| 117 | + return err |
| 118 | + } |
| 119 | + if oldVersion <= 0 { |
| 120 | + return fmt.Errorf("open build issue version must be positive") |
| 121 | + } |
| 122 | + |
| 123 | + result, err := s.db.ExecContext(ctx, |
| 124 | + `DELETE FROM open_build_issue |
| 125 | + WHERE queue = ? AND task_id = ? AND unit_id = ? AND first_observed_build_id = ? AND version = ?`, |
| 126 | + s.queue, issue.TaskID, issue.UnitID, issue.FirstObservedBuildID, oldVersion) |
| 127 | + if err != nil { |
| 128 | + return fmt.Errorf("failed to delete open build issue: %w", err) |
| 129 | + } |
| 130 | + |
| 131 | + return checkOpenBuildIssueMutation(result) |
| 132 | +} |
| 133 | + |
| 134 | +func (s *openBuildIssueStore) validateIssue(issue entity.OpenBuildIssue, requireLastBuild bool) error { |
| 135 | + if err := validateBuildIssueKey(s.queue, issue.FirstObservedBuildID, issue.TaskID, issue.UnitID); err != nil { |
| 136 | + return err |
| 137 | + } |
| 138 | + if issue.FirstObservedBuildID == "" { |
| 139 | + return fmt.Errorf("open build issue first-observed build ID must not be empty") |
| 140 | + } |
| 141 | + if requireLastBuild { |
| 142 | + if err := validateBuildIssueKey(s.queue, issue.LastObservedBuildID, issue.TaskID, issue.UnitID); err != nil { |
| 143 | + return err |
| 144 | + } |
| 145 | + if issue.LastObservedBuildID == "" { |
| 146 | + return fmt.Errorf("open build issue last-observed build ID must not be empty") |
| 147 | + } |
| 148 | + } |
| 149 | + |
| 150 | + return nil |
| 151 | +} |
| 152 | + |
| 153 | +func checkOpenBuildIssueMutation(result sql.Result) error { |
| 154 | + n, err := result.RowsAffected() |
| 155 | + if err != nil { |
| 156 | + return fmt.Errorf("failed to get open build issue rows affected: %w", err) |
| 157 | + } |
| 158 | + if n != 1 { |
| 159 | + return storage.ErrVersionMismatch |
| 160 | + } |
| 161 | + |
| 162 | + return nil |
| 163 | +} |
0 commit comments