Merge pull request #77 from twisted/77-special-var-names

`__version__` is not a violation of the Twisted naming convention.

Author: adiroiban

twistedchecker/configuration/pylintrc

@@ -63,7 +63,7 @@ function-rgx=((([a-z])|([a-z]+_[a-z]))[a-zA-Z0-9]+)$|(__[a-z]+__)$|(\_.+)$|(test
 # Attribute names should be in mixed case, with the first letter lower case,
 # each word separated by having its first letter capitalized just like method names.
 # And all private names should begin with an underscore.
-attr-rgx=(((([a-z_])|([a-z]+_[a-z]))[a-zA-Z0-9]+)|(([A-Z_][A-Z0-9_]*)))$
+attr-rgx=(((([a-z_])|([a-z]+_[a-z])|(__))[a-zA-Z0-9]+|(__))|(([A-Z_][A-Z0-9_]*)))$
 
 # Classes are to be named in mixed case, with the first letter capitalized,
 # each word separated by having its first letter capitalized.

…er/functionaltests/attributename_pass.py …checker/functionaltests/attributename.pytwistedchecker/functionaltests/attributename_pass.py renamed to twistedchecker/functionaltests/attributename.py twistedchecker/functionaltests/attributename_pass.py renamed to twistedchecker/functionaltests/attributename.py

@@ -13,8 +13,21 @@ def __init__(self):
         """
         A init of this class
         """
+        # Bad names.
+        self.foo_bar_zar = None
+        self.FooBarZar = None
+        self.a = None
+        self._fooBar_ = None
+        self._fooBar__ = None
+        self.__fooBar_ = None
+
+        # Good names.
         self.fooBarZar = None
         self._fooBarZar = None
         self.foobar = None
+        self.__foobar__ = None
+        self.__fooBar__ = None
+        self.__dict__ = {}
+        self.__version__ = {}
         # In some cases constants are lazy initialized as instance members.
         self.FOOBARZAR = None

twistedchecker/functionaltests/attributename.result

@@ -0,0 +1,6 @@
+20:C0103
+21:C0103
+23:C0103
+18:C0103
+17:C0103
+19:C0103